Skip to content

rustdoc-json: Add test for #[optimize(..)] #142916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

rustdoc-json: Add test for #[optimize(..)] #142916

wants to merge 1 commit into from

Conversation

aDotInTheVoid
Copy link
Member

@rustbot rustbot added A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jun 23, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 23, 2025

These commits modify tests/rustdoc-json.
rustdoc-json is a public (but unstable) interface.

Please ensure that if you've changed the output:

  • It's intentional.
  • The FORMAT_VERSION in src/librustdoc-json-types is bumped if necessary.

cc @aDotInTheVoid, @obi1kenobi

@aDotInTheVoid aDotInTheVoid added the F-optimize_attribute `#![feature(optimize_attribute)]` label Jun 23, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-cloud-vms rust-cloud-vms bot force-pushed the you-can-trip-on-my-optimizer branch from b813851 to bec2679 Compare June 23, 2025 17:23
@jdonszelmann
Copy link
Contributor

What makes the test for this attr specifically useful? Since a bunch of them are changing which don't necessarily have tests either?

@jdonszelmann
Copy link
Contributor

Don't get me wrong, not against more tests, was just wondering about specifically this one

@aDotInTheVoid
Copy link
Member Author

I wrote it while working on rust-lang/rustdoc-types@33243c4, and wanted to see what exactly the difference was. It will also be useful for when #141358 happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
A-rustdoc-json Area: Rustdoc JSON backend F-optimize_attribute `#![feature(optimize_attribute)]` S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aDotInTheVoid @rustbot @rust-log-analyzer @jdonszelmann @GuillaumeGomez