Skip to content

Enable reproducible-build-2 for Windows #142843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Enable reproducible-build-2 for Windows #142843

wants to merge 1 commit into from
+27 −10

Conversation

dpaoliello
Copy link
Contributor

Works with MSVC if instructing the linker to avoid timestamps and deleting the PDB between compilations.

Addresses item in #128602

try-job: x86_64-mingw-*
try-job: x86_64-msvc-*
try-job: i686-msvc-*

@rustbot
Copy link
Collaborator

rustbot commented Jun 21, 2025

jieyouxu is not on the review rotation at the moment.
They may take a while to respond.

@rustbot
Copy link
Collaborator

rustbot commented Jun 21, 2025

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 21, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 21, 2025

The run-make-support library was changed

cc @jieyouxu

This PR modifies run-make tests.

cc @jieyouxu

@Noratrieb
Copy link
Member

@bors2 try

@rust-bors
Copy link

rust-bors bot commented Jun 21, 2025

⌛ Trying commit e3bd3be with merge c6ea3a5…

To cancel the try build, run the command @bors2 try cancel.

rust-bors bot added a commit that referenced this pull request Jun 21, 2025
@rust-bors
Auto merge of #142843 - dpaoliello:reproducible-build-2, r=<try>
c6ea3a5 
Enable reproducible-build-2 for Windows

Works with MSVC if instructing the linker to avoid timestamps and deleting the PDB between compilations.

Addresses item in #128602

---

try-job: x86_64-mingw-*
try-job: x86_64-msvc-*
try-job: i686-msvc-*
jieyouxu
jieyouxu reviewed Jun 21, 2025
View reviewed changes
src/tools/run-make-support/src/targets.rs
@@ -28,6 +28,12 @@ pub fn is_windows_gnu() -> bool {
target().ends_with("windows-gnu")
}

/// Check if target is windows-gnu.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: msvc

@rust-bors
Copy link

rust-bors bot commented Jun 22, 2025

💔 Test failed

@jieyouxu
Copy link
Member

@bors2 delegate=try

@rust-bors
Copy link

rust-bors bot commented Jun 22, 2025

@dpaoliello can now perform try builds on this pull request

@jieyouxu
Copy link
Member 

2025-06-22T00:32:58.1551644Z ---- [run-make] tests\run-make\reproducible-build-2 stdout ----
2025-06-22T00:32:58.1552110Z 
2025-06-22T00:32:58.1555060Z error: rmake recipe failed to complete
2025-06-22T00:32:58.1555724Z status: exit code: 101
2025-06-22T00:32:58.1556440Z command: "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\run-make\\reproducible-build-2\\rmake.exe"
2025-06-22T00:32:58.1557299Z stdout: none
2025-06-22T00:32:58.1557688Z --- stderr -------------------------------
2025-06-22T00:32:58.1558035Z 
2025-06-22T00:32:58.1558466Z thread 'main' panicked at D:\a\rust\rust\tests\run-make\reproducible-build-2\rmake.rs:29:5:
2025-06-22T00:32:58.1559969Z the file "reproducible-build" could not be moved over to "reproducible-build-a": Os { code: 2, kind: NotFound, message: "The system cannot find the file specified." }
2025-06-22T00:32:58.1561219Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2025-06-22T00:32:58.1561868Z ------------------------------------------

@rustbot author

@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 23, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 23, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@rustbot rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu left review comments

Assignees

@jieyouxu jieyouxu

Labels
A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dpaoliello @rustbot @Noratrieb @jieyouxu