Skip to content

Bump the version number to 1.90.0 #142792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2025
Merged

Bump the version number to 1.90.0 #142792

merged 1 commit into from
Jun 23, 2025
+1 −1

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Jun 20, 2025

Part of the release process. This PR must not be rolled up.

r? cuviper

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels Jun 20, 2025
@cuviper
Copy link
Member Author

cuviper commented Jun 20, 2025

@bors r+ p=1 rollup=never

@bors
Copy link
Collaborator

bors commented Jun 20, 2025

📌 Commit 8c9cafb has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 20, 2025
@bors
Copy link
Collaborator

bors commented Jun 21, 2025

⌛ Testing commit 8c9cafb with merge 440d05c...

bors added a commit that referenced this pull request Jun 21, 2025
@bors
Auto merge of #142792 - cuviper:version-1.90, r=cuviper
440d05c 
Bump the version number to 1.90.0

Part of the release process. This PR must not be rolled up.

r? cuviper
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-aux failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Collaborator

bors commented Jun 21, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 21, 2025
@cuviper
Copy link
Member Author

cuviper commented Jun 22, 2025

@rust-lang/cargo it looks like a couple of your tests are not prepared for the actual 1.90?

---- expected: tests/testsuite/rust_version.rs:573:27
++++ actual:   stderr
   1    1 | [UPDATING] `dummy-registry` index
   2    2 | [LOCKING] 2 packages to latest compatible versions
   3      - [ADDING] newer-and-older v1.6.0 (requires Rust 1.90.0)
   4      - [ADDING] only-newer v1.6.0 (requires Rust 1.90.0)

cuviper added a commit to cuviper/cargo that referenced this pull request Jun 22, 2025
@cuviper
test(msrv): use a far future "newer" version
d97bf41 
Two tests were using `.rust_version("1.90.0")` for a "newer" Rust, but
this failed in rust-lang/rust#142792 for the start of the *real* 1.90.0.
Let's bump that to 1.999.0 so we won't have to deal with it for a while.
@cuviper cuviper mentioned this pull request Jun 22, 2025
Merged
github-merge-queue bot pushed a commit to rust-lang/cargo that referenced this pull request Jun 22, 2025
@ehuss
test(msrv): use a far future "newer" version (#15693)
4832e11 
Two tests were using `.rust_version("1.90.0")` for a "newer" Rust, but
this failed in rust-lang/rust#142792 for the start of the *real* 1.90.0.
Let's bump that to 1.999.0 so we won't have to deal with it for a while.
@ehuss
Copy link
Contributor

ehuss commented Jun 23, 2025

Update is up at #142898

@tgross35
Copy link
Contributor

The Cargo PR merged

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 23, 2025
@bors
Copy link
Collaborator

bors commented Jun 23, 2025

⌛ Testing commit 8c9cafb with merge ae2fc97...

@bors
Copy link
Collaborator

bors commented Jun 23, 2025

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing ae2fc97 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 23, 2025
@bors bors merged commit ae2fc97 into rust-lang:master Jun 23, 2025
11 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jun 23, 2025
@github-actions GitHub Actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 22be76b (parent) -> ae2fc97 (this PR)

Test differences

Show 1 test diff

Stage 2

  • [run-make] tests/run-make/compressed-debuginfo-zstd: pass -> ignore (ignored if LLVM wasn't build with zstd for ELF section compression (we want LLVM/LLD to be built with zstd support)) (J0)

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard ae2fc9722f08ef131407c1dc8057768868f65e8e --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. mingw-check-1: 1638.3s -> 2588.4s (58.0%)
  2. x86_64-rust-for-linux: 2495.9s -> 3930.5s (57.5%)
  3. mingw-check-2: 1890.8s -> 2855.0s (51.0%)
  4. x86_64-gnu-tools: 3252.4s -> 4782.3s (47.0%)
  5. aarch64-apple: 4729.0s -> 6557.2s (38.7%)
  6. armhf-gnu: 4525.1s -> 5986.0s (32.3%)
  7. x86_64-gnu-miri: 4568.7s -> 5994.0s (31.2%)
  8. x86_64-gnu: 6681.3s -> 8439.6s (26.3%)
  9. test-various: 4460.4s -> 5576.4s (25.0%)
  10. dist-aarch64-apple: 5873.9s -> 7217.7s (22.9%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cuviper cuviper

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.90.0
Development

Successfully merging this pull request may close these issues.
6 participants
@cuviper @bors @rust-log-analyzer @ehuss @tgross35 @rustbot