Skip to content

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Jun 16, 2025

@rustbot
Copy link
Collaborator

rustbot commented Jun 16, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 16, 2025
@bjorn3 bjorn3 mentioned this pull request Jun 16, 2025
@rust-log-analyzer

This comment has been minimized.

@bjorn3 bjorn3 force-pushed the wasm32_unknown_naked_asm_test branch from 10fa79f to d28fabe Compare June 16, 2025 08:26
@RalfJung
Copy link
Member

LGTM... r=me unless you think this needs someone who actually knows anything about wasm to take a look.^^
Cc @alexcrichton

@bjorn3
Copy link
Member Author

bjorn3 commented Jun 16, 2025

@bors r=RalfJung

@bors
Copy link
Collaborator

bors commented Jun 16, 2025

📌 Commit d28fabe has been approved by RalfJung

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 16, 2025
bors added a commit that referenced this pull request Jun 16, 2025
Rollup of 8 pull requests

Successful merges:

 - #139340 (Fix RISC-V C function ABI when passing/returning structs containing floats)
 - #142341 (Don't suggest converting `///` to `//` when expecting `,`)
 - #142414 (ignore `run-make` tests that need `std` on targets without `std`)
 - #142498 (Port `#[rustc_as_ptr]` to the new attribute system)
 - #142554 (Fix `PathSource` lifetimes.)
 - #142562 (Update the `backtrace` submodule)
 - #142565 (Test naked asm for wasm32-unknown-unknown)
 - #142573 (`fn candidate_is_applicable` to method)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a53c1d7 into rust-lang:master Jun 16, 2025
10 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 16, 2025
rust-timer added a commit that referenced this pull request Jun 16, 2025
Rollup merge of #142565 - bjorn3:wasm32_unknown_naked_asm_test, r=RalfJung

Test naked asm for wasm32-unknown-unknown

cc #133952 (comment)
@bjorn3 bjorn3 deleted the wasm32_unknown_naked_asm_test branch June 16, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants