Skip to content

Conversation

mati865
Copy link
Member

@mati865 mati865 commented May 31, 2025

Based on #140828

I don't have AArch64 Windows to test it, but I trust LLVM to handle it well.

@rustbot
Copy link
Collaborator

rustbot commented May 31, 2025

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 31, 2025
@rustbot
Copy link
Collaborator

rustbot commented May 31, 2025

These commits modify compiler targets.
(See the Target Tier Policy.)

@workingjubilee
Copy link
Member

Yeah, same idea as the previous PR, same principle, mati knows the target, etc.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 31, 2025

📌 Commit 7e9aee7 has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 31, 2025
bors added a commit that referenced this pull request May 31, 2025
Rollup of 8 pull requests

Successful merges:

 - #140787 (Note expr being cast when encounter NonScalar cast error)
 - #141112 (std: note that `std::str::from_utf8*` functions are aliases to `<str>::from_utf8*` methods)
 - #141646 (Document what `distcheck` is intended to exercise)
 - #141740 (Hir item kind field order)
 - #141793 (`tests/ui`: A New Order [1/N])
 - #141805 (Update `compiler-builtins` to 0.1.160)
 - #141815 (Enable non-leaf Frame Pointers for mingw-w64 Arm64 Windows)
 - #141819 (Fixes for building windows-gnullvm hosts)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0254c67 into rust-lang:master May 31, 2025
9 checks passed
@rustbot rustbot added this to the 1.89.0 milestone May 31, 2025
rust-timer added a commit that referenced this pull request May 31, 2025
Rollup merge of #141815 - mati865:mingw-aarch64-frame-pointers, r=workingjubilee

Enable non-leaf Frame Pointers for mingw-w64 Arm64 Windows

Based on #140828

I don't have AArch64 Windows to test it, but I trust LLVM to handle it well.
@mati865 mati865 deleted the mingw-aarch64-frame-pointers branch May 31, 2025 22:32
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Jun 3, 2025
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#140787 (Note expr being cast when encounter NonScalar cast error)
 - rust-lang#141112 (std: note that `std::str::from_utf8*` functions are aliases to `<str>::from_utf8*` methods)
 - rust-lang#141646 (Document what `distcheck` is intended to exercise)
 - rust-lang#141740 (Hir item kind field order)
 - rust-lang#141793 (`tests/ui`: A New Order [1/N])
 - rust-lang#141805 (Update `compiler-builtins` to 0.1.160)
 - rust-lang#141815 (Enable non-leaf Frame Pointers for mingw-w64 Arm64 Windows)
 - rust-lang#141819 (Fixes for building windows-gnullvm hosts)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants