Revert "Fix linking statics on Arm64EC #140176" #141024
Open
+54
−201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, multiple people are reporting linker warnings related to `__rust_no_alloc_shim_is_unstable` after this change. The solution isn't quite clear yet, let's revert to green for now, and try a reland with a determined solution for `__rust_no_alloc_shim_is_unstable`. This reverts commit c8b7f32, reversing changes made to 667247d.
rustbot
added
A-run-make
|
Some changes occurred in compiler/rustc_codegen_ssa These commits modify compiler targets. |
|
Nominating this for beta backport because people are reporting seeing the linker warning in bootstrapping as well. However, the beta backport is a "pick your poison" situation, where we avoid the linker warnings in Tier 1 @rustbot label: +beta-nominated |
rustbot
added
the
beta-nominated
|
CI is green. |
|
🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened. |
bors
added
S-waiting-on-bors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts PR #140176.
Unfortunately, this will reopen #138541 (re-breaking the
arm64ec-pc-windows-msvctarget).Unfortunately, multiple people are reporting linker warnings related to
__rust_no_alloc_shim_is_unstableafter this change inx86_64-pc-windows-msvcas well. The solution isn't quite clear yet, let's revert to avoid the linker warnings on the Tier 1 MSVC target for now1, and try a reland with a determined solution for__rust_no_alloc_shim_is_unstable.Judging from people reporting that they are observing this also when bootstrapping w/ stage0 rustc, we may have to cut a new beta and then repoint stage0 against that newer beta?
cc @dpaoliello @wesleywiser
r? @wesleywiser (or compiler)
Footnotes
Note that it's still RustWeek this week, so most team members are N/A. ↩