Skip to content

impl PartialEq<{str,String}> for {Path,PathBuf} #140956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

impl PartialEq<{str,String}> for {Path,PathBuf} #140956

wants to merge 1 commit into from
+71 −8

Conversation

Kixunil
Copy link
Contributor

@Kixunil Kixunil commented May 13, 2025

This is a revival of #105877

Comparison of paths and strings is expected to be possible and needed e.g. in tests. This change adds the impls os PartialEq between strings and paths, both owned and unsized, in both directions.

ACP: rust-lang/libs-team#151

@rustbot
Copy link
Collaborator

rustbot commented May 13, 2025

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 13, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Kixunil Kixunil force-pushed the impl-partialeq-str-for-path branch from 44bb04c to 90838cd Compare May 13, 2025 01:37
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Kixunil Kixunil force-pushed the impl-partialeq-str-for-path branch from 90838cd to c7d5b49 Compare May 13, 2025 01:48
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Kixunil Kixunil force-pushed the impl-partialeq-str-for-path branch from c7d5b49 to f908d17 Compare May 13, 2025 02:32
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Kixunil
impl PartialEq<{str,String}> for {Path,PathBuf}
aab1563 
Comparison of paths and strings is expected to be possible and needed
e.g. in tests. This change adds the impls os `PartialEq` between strings
and paths, both owned and unsized, in both directions.

ACP: rust-lang/libs-team#151
@Kixunil Kixunil force-pushed the impl-partialeq-str-for-path branch from f908d17 to aab1563 Compare May 13, 2025 21:41
@joboet
Copy link
Member

joboet commented May 15, 2025

r? libs-api

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label May 15, 2025
@rustbot rustbot assigned Amanieu and unassigned joboet May 15, 2025
@Amanieu
Copy link
Member

Amanieu commented May 18, 2025

Starting a crater run since we've previously had type inference issues with PartialEq.

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request May 18, 2025
@bors
Auto merge of rust-lang#140956 - Kixunil:impl-partialeq-str-for-path,…
afeffcd 
… r=<try>

`impl PartialEq<{str,String}> for {Path,PathBuf}`

This is a revival of rust-lang#105877

Comparison of paths and strings is expected to be possible and needed e.g. in tests. This change adds the impls os `PartialEq` between strings and paths, both owned and unsized, in both directions.

ACP: rust-lang/libs-team#151
@bors
Copy link
Collaborator

bors commented May 18, 2025

⌛ Trying commit aab1563 with merge afeffcd...

@bors
Copy link
Collaborator

bors commented May 18, 2025

☀️ Try build successful - checks-actions
Build commit: afeffcd (afeffcd090fe6cee35c99f8b5539d74aa443fe34)

@Amanieu
Copy link
Member

Amanieu commented Jun 24, 2025

@craterbot check

@craterbot
Copy link
Collaborator

👌 Experiment pr-140956 created and queued.
🤖 Automatically detected try build afeffcd
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 24, 2025
@craterbot
Copy link
Collaborator

🚧 Experiment pr-140956 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-140956 is completed!
📊 2 regressed and 5 fixed (652938 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jun 26, 2025
@Kixunil
Copy link
Contributor Author

Kixunil commented Jun 26, 2025

If I'm looking at the report correctly (it's crashing my browser, I had to read it in source code :D) the two regressions are unrelated and supposed fixes are likely unrelated as well.

@Amanieu
Copy link
Member

Amanieu commented Jun 26, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 26, 2025

📌 Commit aab1563 has been approved by Amanieu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 26, 2025
@Amanieu
Copy link
Member

Amanieu commented Jun 26, 2025

@bors r-

Actually this still needs to go through FCP.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 26, 2025
@Amanieu
Copy link
Member

Amanieu commented Jun 26, 2025

@rfcbot merge

@rfcbot
Copy link
Collaborator

rfcbot commented Jun 26, 2025 •
edited
Loading

Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Jun 26, 2025
@Amanieu Amanieu removed the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jun 26, 2025
@Amanieu
Copy link
Member

Amanieu commented Jun 26, 2025

@rfcbot cancel

@rfcbot
Copy link
Collaborator

rfcbot commented Jun 26, 2025

@Amanieu proposal cancelled.

@rfcbot rfcbot removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Jun 26, 2025
@Amanieu
Copy link
Member

Amanieu commented Jun 26, 2025

@rfcbot merge

@rfcbot
Copy link
Collaborator

rfcbot commented Jun 26, 2025 •
edited by dtolnay
Loading

Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Amanieu Amanieu

Labels
disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Kixunil @rustbot @rust-log-analyzer @joboet @Amanieu @bors @craterbot @rfcbot