Skip to content

Use new form for T-rustdoc's {beta,stable}-{nominated,accepted} notify-Zulip triggers #140909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025

Conversation

fmease
Copy link
Member

@fmease fmease commented May 10, 2025

@rustbot
Copy link
Collaborator

rustbot commented May 10, 2025

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 10, 2025
@fmease fmease added the T-triagebot Relevant to the triagebot team, which will review and decide on the PR/issue. label May 10, 2025
@apiraino
Copy link
Contributor

@fmease do you have privileges to push #140397 in a rollup? I guess either this patch or mine will need a rebase.

@fmease
Copy link
Member Author

fmease commented May 11, 2025

I'm fine either way, I can also drop the FIXME removals so you don't need to deal with it.

Re. the T-compiler PR, ofc me or you could put it into the queue since one team lead has already approved but I'm not sure if you'd like to wait for the second one, too?

@bors

This comment was marked as resolved.

@fmease fmease force-pushed the modern-notif-backport-rustdoc branch from bcbfe43 to 42d3ba7 Compare May 12, 2025 11:46
@fmease
Copy link
Member Author

fmease commented May 12, 2025

I take this as an approval.
@bors r=apiraino rollup

@bors
Copy link
Collaborator

bors commented May 12, 2025

📌 Commit 42d3ba7 has been approved by apiraino

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 12, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request May 12, 2025
…, r=apiraino

Use new form for T-rustdoc's {beta,stable}-{nominated,accepted} notify-Zulip triggers

Applies [#t-rustdoc > PSA: New actions on backport notifs @ 💬](https://rust-lang.zulipchat.com/#narrow/channel/266220-t-rustdoc/topic/PSA.3A.20New.20actions.20on.20backport.20notifs/near/514823133).
Complements rust-lang#140397.

r? `@apiraino` or T-triagebot
@bors
Copy link
Collaborator

bors commented May 12, 2025

⌛ Testing commit 42d3ba7 with merge ad1f98f...

@bors
Copy link
Collaborator

bors commented May 12, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 12, 2025
@fmease
Copy link
Member Author

fmease commented May 12, 2025

What? And I can't inspect the raw logs. GH why. This has to be spurious
@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 12, 2025
@bors
Copy link
Collaborator

bors commented May 12, 2025

⌛ Testing commit 42d3ba7 with merge 8405332...

@bors
Copy link
Collaborator

bors commented May 13, 2025

☀️ Test successful - checks-actions
Approved by: apiraino
Pushing 8405332 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 13, 2025
@bors bors merged commit 8405332 into rust-lang:master May 13, 2025
7 checks passed
@rustbot rustbot added this to the 1.89.0 milestone May 13, 2025
@fmease fmease deleted the modern-notif-backport-rustdoc branch May 13, 2025 00:03
Copy link

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 1a7f290 (parent) -> 8405332 (this PR)

Test differences

Show 33150 test diffs

Stage 1

  • arc::float_nan_ne: pass -> [missing] (J0)
  • array::array_intoiter_advance_by: pass -> [missing] (J0)
  • cmp::test_ord_min_max_by_key: pass -> [missing] (J0)
  • collections::btree::set::tests::test_is_disjoint: pass -> [missing] (J0)
  • f128::test_is_sign_negative: pass -> [missing] (J0)
  • f32::test_ln: pass -> [missing] (J0)
  • f64::test_powi: pass -> [missing] (J0)
  • ffi::os_str::tests::test_os_string_default: pass -> [missing] (J0)
  • instant_checked_duration_since_nopanic: pass -> [missing] (J0)
  • io::borrowed_buf::initialize_unfilled: pass -> [missing] (J0)
  • io::copy::tests::copy_specializes_to_vec: pass -> [missing] (J0)
  • io::cursor::tests::test_boxed_slice_reader: pass -> [missing] (J0)
  • iter::adapters::chain::test_iterator_chain: pass -> [missing] (J0)
  • iter::adapters::cycle::test_cycle: pass -> [missing] (J0)
  • iter::adapters::enumerate::test_iterator_enumerate_advance_by: pass -> [missing] (J0)
  • iter::adapters::intersperse::test_try_fold_specialization_intersperse_ok: pass -> [missing] (J0)
  • mem::size_of_64: pass -> [missing] (J0)
  • num::dec2flt::parse::missing_pieces: pass -> [missing] (J0)
  • num::f32::min: pass -> [missing] (J0)
  • num::i128::test_le: pass -> [missing] (J0)
  • num::int_log::checked_ilog10: pass -> [missing] (J0)
  • num::test_try_isizeu64: pass -> [missing] (J0)
  • num::u32::test_isolate_least_significant_one: pass -> [missing] (J0)
  • num::u32::test_overflows: pass -> [missing] (J0)
  • rwlock::test_rw_arc_poison_ww: pass -> [missing] (J0)
  • sort::tests::stable::panic_retain_orig_set_cell_i32_random_z1: pass -> [missing] (J0)
  • sort::tests::unstable::observable_is_less_random_z1: pass -> [missing] (J0)
  • vec::extract_if_zst: pass -> [missing] (J0)
  • vec_deque::test_eq: pass -> [missing] (J0)
  • vec_deque::truncate_front_leak: pass -> [missing] (J0)
  • errors::verify_codegen_ssa_copy_path_buf_32: pass -> [missing] (J1)
  • errors::verify_codegen_ssa_unknown_atomic_ordering_86: pass -> [missing] (J1)
  • errors::verify_parse_missing_expression_in_for_loop_22: pass -> [missing] (J1)
  • errors::verify_passes_unexportable_type_repr_179: pass -> [missing] (J1)
  • errors::verify_resolve_underscore_lifetime_is_reserved_47: pass -> [missing] (J1)
  • html::highlight::tests::test_html_highlighting: pass -> [missing] (J1)
  • html::length_limit::tests::quickly_past_the_limit: pass -> [missing] (J1)
  • lints::verify_lint_unused_comparisons_87: pass -> [missing] (J1)
  • maybe_transmutable::tests::benches::bench_transmute: pass -> [missing] (J1)
  • spec::tests::mips64_openwrt_linux_musl: pass -> [missing] (J1)
  • spec::tests::thumbv6m_none_eabi: pass -> [missing] (J1)
  • spec::tests::x86_64_unknown_l4re_uclibc: pass -> [missing] (J1)
  • spec::tests::xtensa_esp32_espidf: pass -> [missing] (J1)
  • tests::invalid_position: pass -> [missing] (J1)
  • ascii::is_ascii::medium::case01_iter_all: pass -> [missing] (J2)
  • btree::set::difference_staggered_100_vs_10k: pass -> [missing] (J2)
  • iter::bench_zip_then_skip: pass -> [missing] (J2)
  • linked_list::bench_push_back: pass -> [missing] (J2)
  • sort::tests::stable::correct_f128_random: pass -> [missing] (J2)
  • sort::tests::stable::stability_i32_saw_mixed: pass -> [missing] (J2)
  • sort::tests::unstable::observable_is_less_saw_mixed: pass -> [missing] (J2)
  • vec::bench_in_place_xxu8_1000_i0: pass -> [missing] (J2)
  • sort::tests::stable::observable_is_less_random: ignore -> [missing] (J3)
  • sort::tests::stable::stability_i32_random_d2: ignore -> [missing] (J3)

Stage 2

  • char::eu_iterator_specializations: [missing] -> pass (J0)
  • collections::btree::map::tests::test_append_9: [missing] -> pass (J0)
  • display_format_flags: [missing] -> pass (J0)
  • io::buffered::tests::test_buffered_reader_invalidated_after_read: [missing] -> pass (J0)
  • iter::adapters::intersperse::test_try_fold_specialization_intersperse_err: [missing] -> pass (J0)
  • iter::adapters::take::test_iterator_take_nth_back: [missing] -> pass (J0)
  • iter::range::test_range_inclusive_nth_back: [missing] -> pass (J0)
  • iter::test_monad_laws_right_identity: [missing] -> pass (J0)
  • num::i128::test_rotate: [missing] -> pass (J0)
  • num::test_try_i64u32: [missing] -> pass (J0)
  • num::test_u8u16: [missing] -> pass (J0)
  • slice::memchr::no_match_empty_reversed: [missing] -> pass (J0)
  • slice::split_off_mut_oob_range_from: [missing] -> pass (J0)
  • slice::test_binary_search: [missing] -> pass (J0)
  • slice::test_rchunks_exact_mut_count: [missing] -> pass (J0)
  • slice::test_rchunks_exact_remainder: [missing] -> pass (J0)
  • sys_common::wtf8::tests::wtf8buf_extend: [missing] -> pass (J0)
  • vec::extract_if_complex: [missing] -> pass (J0)
  • vec::test_splice: [missing] -> pass (J0)
  • bit_set::tests::matrix_intersection: [missing] -> pass (J1)
  • error::verify_middle_type_length_limit_16: [missing] -> pass (J1)
  • errors::verify_const_eval_unmarked_const_item_exposed_13: [missing] -> pass (J1)
  • errors::verify_mir_transform_unaligned_packed_ref_4: [missing] -> pass (J1)
  • errors::verify_parse_visibility_not_followed_by_item_74: [missing] -> pass (J1)
  • spec::tests::aarch64_unknown_nto_qnx800: [missing] -> pass (J1)
  • spec::tests::thumbv5te_none_eabi: [missing] -> pass (J1)
  • transitive_relation::tests::mubs_scc_3: [missing] -> pass (J1)
  • btree::map::clone_fat_val_100_and_drain_half: [missing] -> pass (J2)
  • btree::map::clone_slim_10k_and_clear: [missing] -> pass (J2)
  • btree::set::difference_random_10k_vs_100: [missing] -> pass (J2)
  • fmt::write_vec_macro1: [missing] -> pass (J2)
  • fs::tests::copy_file_does_not_exist: [missing] -> pass (J2)
  • fs::tests::unicode_path_is_dir: [missing] -> pass (J2)
  • net::socket_addr::tests::to_socket_addr_str_u16: [missing] -> pass (J2)
  • num::bench_u16_from_str: [missing] -> pass (J2)
  • num::bench_u16_from_str_radix_16: [missing] -> pass (J2)
  • num::int_sqrt::u64_sqrt_uniform: [missing] -> pass (J2)
  • sort::tests::stable::correct_string_random_s95: [missing] -> pass (J2)
  • sort::tests::stable::panic_retain_orig_set_cell_i32_random_d2: [missing] -> pass (J2)
  • sort::tests::unstable::violate_ord_retain_orig_set_i32_random_d20: [missing] -> pass (J2)
  • sort::tests::unstable::correct_i32_random_d1024: [missing] -> ignore (J3)
  • sort::tests::unstable::correct_i32_random_d4: [missing] -> ignore (J3)
  • sort::tests::unstable::deterministic_string_descending: [missing] -> ignore (J3)
  • task::test_local_waker_will_wake_clone: [missing] -> ignore (J3)
  • task::test_waker_will_wake_clone: [missing] -> ignore (J3)
  • sys::process::unix::common::tests::test_process_group_no_posix_spawn: [missing] -> pass (J4)

(and 16504 additional test diffs)

Additionally, 16546 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 8405332bdf09b153e475f83b8b8ebf8d4e8eb81f --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-apple-2: 6768.4s -> 1252.5s (-81.5%)
  2. test-various: 4161.5s -> 2349.0s (-43.6%)
  3. x86_64-apple-1: 9106.8s -> 5489.6s (-39.7%)
  4. aarch64-apple: 4330.1s -> 3062.2s (-29.3%)
  5. x86_64-gnu-aux: 5984.9s -> 4281.0s (-28.5%)
  6. dist-apple-various: 7193.3s -> 6139.6s (-14.6%)
  7. dist-various-1: 4883.2s -> 4511.1s (-7.6%)
  8. dist-x86_64-apple: 8742.1s -> 8102.6s (-7.3%)
  9. dist-aarch64-apple: 5673.1s -> 6077.6s (7.1%)
  10. x86_64-gnu-llvm-19-3: 6860.1s -> 7332.0s (6.9%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (8405332): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 0.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.4% [0.4%, 0.4%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.4% [0.4%, 0.4%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 772.98s -> 773.027s (0.01%)
Artifact size: 365.34 MiB -> 365.35 MiB (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-triagebot Relevant to the triagebot team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants