Add is_inner information to rustdoc-json-types

[GuillaumeGomez]

Part of #137645.

Since it adds more information for attributes, I suppose the next step could be to add span on them as well.

cc @Urgau for the compiler changes.
r? @aDotInTheVoid

[rustbot]

Some changes occurred in tests/rustdoc-json

cc @aDotInTheVoid

rustdoc-json-types is a public (although nightly-only) API. If possible, consider changing src/librustdoc/json/conversions.rs; otherwise, make sure you bump the FORMAT_VERSION constant.

cc @CraftSpider, @aDotInTheVoid, @Enselic, @obi1kenobi

[GuillaumeGomez]

Removed the extra empty line at the end of the file. ^^'

[Urgau]

Compiler changes looks good.

[aDotInTheVoid]

What's the purpose of doing this? Is their any time when someone would want this information from rustdoc-json?

My instinct is that the differentiation between inner and outer attributes is purely syntactic, and therefor it's fine for rustdoc-json to not contain this information.

[GuillaumeGomez]

I have to admit that I mostly wanted a pretext to add a new Attribute type to be able to add Span information to attributes. I can still do it instead of adding the is_inner information.

[GuillaumeGomez]

Now that I think about it: some attributes are only allowed to be inner only (and at crate levels). I think it's actually kinda important to allow users to know if it's inner or outer because of this.

[aDotInTheVoid]

I have to admit that I mostly wanted a pretext to add a new Attribute type to be able to add Span information to attributes

What use-case do you have for this?

Now that I think about it: some attributes are only allowed to be inner only (and at crate levels). I think it's actually kinda important to allow users to know if it's inner or outer because of this.

Why? In what case does a rustdoc-json consumer need to know if an item is inner or outer.

[GuillaumeGomez]

I have to admit that I mostly wanted a pretext to add a new Attribute type to be able to add Span information to attributes

What use-case do you have for this?

Same as for other spans I suppose? But if you don't think it's ever useful, it's fine not to add it. I'm not a rustdoc JSON user after all. 😆

Now that I think about it: some attributes are only allowed to be inner only (and at crate levels). I think it's actually kinda important to allow users to know if it's inner or outer because of this.

Why? In what case does a rustdoc-json consumer need to know if an item is inner or outer.

Well, no idea. So maybe never?

[aDotInTheVoid]

I think in that case I'm gonna close this. If someone has a use-case for when they'd want this information, I'd be happy to reconsider.

[GuillaumeGomez]

No problem! :)