rustc_feature: Avoid unsafe std::env::set_var() in UnstableFeatures tests
#135245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s` tests
Avoid unsafe `std::env::set_var()` by allowing tests to inject
`std::env::var("RUSTC_BOOTSTRAP")` with a `env_var_rustc_bootstrap`
parameter.
|
r? @davidtwco rustbot has assigned @davidtwco. Use |
rustbot
added
S-waiting-on-review
davidtwco
approved these changes
Jan 13, 2025
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 13, 2025
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#133752 (replace copypasted ModuleLlvm::parse) - rust-lang#135245 (rustc_feature: Avoid unsafe `std::env::set_var()` in `UnstableFeatures` tests) - rust-lang#135405 (path: Move is_absolute check to sys::path) - rust-lang#135426 (Assert that `Instance::try_resolve` is only used on body-like things) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 13, 2025
Rollup of 4 pull requests Successful merges: - rust-lang#133752 (replace copypasted ModuleLlvm::parse) - rust-lang#135245 (rustc_feature: Avoid unsafe `std::env::set_var()` in `UnstableFeatures` tests) - rust-lang#135405 (path: Move is_absolute check to sys::path) - rust-lang#135426 (Assert that `Instance::try_resolve` is only used on body-like things) r? `@ghost` `@rustbot` modify labels: rollup try-job: x86_64-mingw-1
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 14, 2025
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#133752 (replace copypasted ModuleLlvm::parse) - rust-lang#135245 (rustc_feature: Avoid unsafe `std::env::set_var()` in `UnstableFeatures` tests) - rust-lang#135405 (path: Move is_absolute check to sys::path) - rust-lang#135426 (Assert that `Instance::try_resolve` is only used on body-like things) r? `@ghost` `@rustbot` modify labels: rollup try-job: x86_64-mingw-1
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 14, 2025
Rollup merge of rust-lang#135245 - Enselic:no-set-env, r=davidtwco rustc_feature: Avoid unsafe `std::env::set_var()` in `UnstableFeatures` tests Avoid unsafe `std::env::set_var()` by allowing tests to inject `std::env::var("RUSTC_BOOTSTRAP")` with a `env_var_rustc_bootstrap` parameter. Part of rust-lang#130672 Discussed at rust-lang#129636 (comment) (CC `@compiler-errors` `@bjorn3)`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid unsafe
std::env::set_var()by allowing tests to injectstd::env::var("RUSTC_BOOTSTRAP")with aenv_var_rustc_bootstrapparameter.Part of #130672
Discussed at #129636 (comment) (CC @compiler-errors @bjorn3)