Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UWP (msvc) target support page #134996

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

bdbai
Copy link
Contributor

@bdbai bdbai commented Jan 1, 2025

r? jieyouxu

@rustbot rustbot added O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 1, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jan 1, 2025

Some changes occurred in src/doc/rustc/src/platform-support

cc @Noratrieb

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@jieyouxu
Copy link
Member

jieyouxu commented Jan 2, 2025

You probably need to run ./x fmt locally (or just use the fmt diff from the error message).

Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, and happy new year to you as well. Could you split the library changes from the platform support doc changes, into two separate commits? It seems like here the first commit has some changes which were reverted by the second and third commit. But otherwise, this LGTM from the compiler side.

Thanks for signing up as the target maintainer for these targets!


## Target maintainers

- @bdbai
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion:

Suggested change
- @bdbai
- [@bdbai](https://github.com/bdbai)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 2389daa

@jieyouxu
Copy link
Member

jieyouxu commented Jan 2, 2025

cc @ChrisDenton (since you're both a libs reviewer and a Windows expert, in case you have any concerns)

@jieyouxu
Copy link
Member

jieyouxu commented Jan 2, 2025

@rustbot author (on the commit history cleanup)

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 2, 2025
@ChrisDenton
Copy link
Member

I'm ok with the libs changes once CI is happy with the formatting. Ideally this would be two separate PRs, one for the libs changes and one for the support update. But the libs change is small so it's not a big deal.

@bdbai bdbai requested a review from jieyouxu January 3, 2025 04:19
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants