-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UWP (msvc) target support page #134996
base: master
Are you sure you want to change the base?
Conversation
Some changes occurred in src/doc/rustc/src/platform-support cc @Noratrieb |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
You probably need to run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, and happy new year to you as well. Could you split the library changes from the platform support doc changes, into two separate commits? It seems like here the first commit has some changes which were reverted by the second and third commit. But otherwise, this LGTM from the compiler side.
Thanks for signing up as the target maintainer for these targets!
|
||
## Target maintainers | ||
|
||
- @bdbai |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion:
- @bdbai | |
- [@bdbai](https://github.com/bdbai) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 2389daa
cc @ChrisDenton (since you're both a libs reviewer and a Windows expert, in case you have any concerns) |
@rustbot author (on the commit history cleanup) |
I'm ok with the libs changes once CI is happy with the formatting. Ideally this would be two separate PRs, one for the libs changes and one for the support update. But the libs change is small so it's not a big deal. |
x86_64-uwp-windows-msvc
,i686-uwp-windows-msvc
,thumbv7a-uwp-windows-msvc
andaarch64-uwp-windows-msvc
thumbv7a-pc-windows-msvc
andthumbv7a-uwp-windows-msvc
as they do not currently build due toraw-dylib
usage in std broke thumbv7a-*-windows-msvc targets #134565 and Attempt to fix ARM32 Windows backtrace-rs#685r? jieyouxu