Rollup of 9 pull requests #134133
Closed
Rollup of 9 pull requests #134133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was accidentally reintroduced while editing rust-lang#133089.
Use verbose suggestions and add additional labels/notes. Add more test cases for stable/nightly and feature enabled/disabled.
It asserted on **stdout**, not stderr.
Add the `power8-crypto` target feature Add the `power8-crypto` target feature. This will enable adding some new PPC intrinsics in stdarch (specifically AES, SHA and CLMUL intrinsics). The implied target feature is from [here](https://github.com/llvm/llvm-project/blob/main/llvm/lib/Target/PowerPC/PPC.td) ``@rustbot`` label A-target-feature O-PowerPC
Some asm! diagnostic adjustments and a papercut fix Best reviewed commit by commit. We forgot a `normalize` call in intrinsic checking, causing us to allow literal integers, but not named constants containing that literal. This can in theory affect stable code, but only if libstd contains a stable SIMD type that has an array length that is a named constant. I'd assume we'd have noticed by now due to asm! rejecting those outright. The error message left me scratching my head for a bit, so I added some extra information to the diagnostic, too.
…piler-errors Tweak wording of non-const traits used as const bounds Use verbose suggestions and add additional labels/notes. r? `@compiler-errors`
…tolnay Remove rustc_const_stable attribute on const NOOP This was accidentally reintroduced while editing rust-lang#133089. r? dtolnay
…=oli-obk Don't ICE when encountering never in range pattern Fixes rust-lang#133947 r? oli-obk
run-make: Fix `assert_stderr_not_contains_regex` It asserted on **stdout**, not stderr. r? `@jieyouxu`
stabilize const_nonnull_new FCP passed in rust-lang#93235 Closes rust-lang#93235
Remove Felix from ping groups and review rotation
rustbot
added
A-meta
|
@bors r+ rollup=never p=5 |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 10, 2024
Rollup of 9 pull requests Successful merges: - rust-lang#134042 (Add the `power8-crypto` target feature) - rust-lang#134070 (Some asm! diagnostic adjustments and a papercut fix) - rust-lang#134094 (Tweak wording of non-const traits used as const bounds) - rust-lang#134100 (Remove rustc_const_stable attribute on const NOOP) - rust-lang#134103 (Don't ICE when encountering never in range pattern) - rust-lang#134113 (run-make: Fix `assert_stderr_not_contains_regex`) - rust-lang#134115 (rustc_target: ppc64 target string fixes for LLVM 20) - rust-lang#134116 (stabilize const_nonnull_new) - rust-lang#134120 (Remove Felix from ping groups and review rotation) r? `@ghost` `@rustbot` modify labels: rollup
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors r- |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
power8-cryptotarget feature #134042 (Add thepower8-cryptotarget feature)assert_stderr_not_contains_regex#134113 (run-make: Fixassert_stderr_not_contains_regex)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup