Recover some lost performence from #132732

[Urgau]

This PR reorders some conditions in the dangling_pointers_from_temporaries lint to avoid some potentially expensive query call, in particular those who could involve some metadata decoding from disk.

cc #132732 (comment)
cc @Kobzol

[rustbot]

r? @Nadrieril

rustbot has assigned @Nadrieril.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[Urgau]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 9b040e9 with merge 404172f...

[bors]

☀️ Try build successful - checks-actions
Build commit: 404172f (404172fcb615d40bcbbb46d79780b3cc441b70f9)

[rust-timer]

Finished benchmarking commit (404172f): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.3%	[0.3%, 0.3%]	1
Improvements ✅ (primary)	-1.4%	[-2.6%, -0.2%]	6
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.4%	[-2.6%, -0.2%]	6

Max RSS (memory usage)

Results (primary -0.9%, secondary -3.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.9%	[-0.9%, -0.9%]	1
Improvements ✅ (secondary)	-3.0%	[-3.0%, -3.0%]	1
All ❌✅ (primary)	-0.9%	[-0.9%, -0.9%]	1

Cycles

Results (primary -2.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.1%	[-2.4%, -1.9%]	3
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.1%	[-2.4%, -1.9%]	3

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 797.491s -> 796.339s (-0.14%)
Artifact size: 336.34 MiB -> 336.36 MiB (0.01%)

[Urgau]

@bors try @rust-timer queue

[bors]

⌛ Trying commit b6c80a6 with merge 45fe5bb...

[bors]

☀️ Try build successful - checks-actions
Build commit: 45fe5bb (45fe5bb168d4ff3d836a12e762ba627661e193f9)

[Noratrieb]

r=me if the numbers look as good or better than the previous run

[rust-timer]

Finished benchmarking commit (45fe5bb): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.6%	[-4.2%, -0.2%]	9
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.6%	[-4.2%, -0.2%]	9

Max RSS (memory usage)

Results (primary 1.6%, secondary 1.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	4.4%	[4.4%, 4.4%]	1
Regressions ❌ (secondary)	4.9%	[4.9%, 4.9%]	1
Improvements ✅ (primary)	-1.2%	[-1.2%, -1.2%]	1
Improvements ✅ (secondary)	-2.8%	[-2.8%, -2.8%]	1
All ❌✅ (primary)	1.6%	[-1.2%, 4.4%]	2

Cycles

Results (primary -3.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.4%	[-3.8%, -3.1%]	3
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-3.4%	[-3.8%, -3.1%]	3

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 793.27s -> 793.253s (-0.00%)
Artifact size: 336.19 MiB -> 336.19 MiB (0.00%)

[Noratrieb]

[bors]

📌 Commit b6c80a6 has been approved by Noratrieb

It is now in the queue for this repository.

[bors]

⌛ Testing commit b6c80a6 with merge 66adeaf...

[bors]

☀️ Test successful - checks-actions
Approved by: Noratrieb
Pushing 66adeaf to master...

[rust-timer]

Finished benchmarking commit (66adeaf): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.7%	[-4.2%, -0.2%]	8
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.7%	[-4.2%, -0.2%]	8

Max RSS (memory usage)

Results (primary -0.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	3.4%	[3.4%, 3.4%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-4.2%	[-4.2%, -4.2%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.4%	[-4.2%, 3.4%]	2

Cycles

Results (primary 0.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.2%	[1.8%, 2.8%]	5
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.6%	[-3.3%, -1.6%]	4
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[-3.3%, 2.8%]	9

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 793.974s -> 794.328s (0.04%)
Artifact size: 335.91 MiB -> 335.88 MiB (-0.01%)