Skip to content

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

he32 and others added 15 commits March 26, 2024 08:39
Tweak variable names in the deadlock example to remove any potential
confusion that the behavior is somehow shadowing-related.
…piler-errors

match lowering: build the `Place` instead of keeping a `PlaceBuilder` around

Outside of `MatchPair::new` we don't construct new places, so we don't need to keep a `PlaceBuilder` around.

A bit annoyingly we have to store an `Option<Place>` even though it's never `None` after simplification, but the alternative would be to re-entangle `MatchPair` construction and simplification and I'd rather not do that.
…kingjubilee

Unix: Support more platforms with `preadv` and `pwritev`

- `aix`, `dragonfly` and `openbsd` with direct call
- `watchos` with weak linkage

cc rust-lang#89517
…bilee

std library thread.rs: fix NetBSD code for ILP32 CPUs.
…ingjubilee

`UnixStream`: override `read_buf`

Split from rust-lang#122441

r? ``@workingjubilee``
…gjubilee

RustWrapper: update call for llvm/llvm-project@44d037cc258dcf179d2c48…

…c93996bb406ecd0fae

Easy change.

`@rustbot` label: +llvm-main
Implement `Vec::pop_if`

This PR adds `Vec::pop_if` to the public API, behind the `vec_pop_if` feature.

```rust
impl<T> Vec<T> {
    pub fn pop_if<F>(&mut self, f: F) -> Option<T>
        where F: FnOnce(&mut T) -> bool;
}
```

Tracking issue: rust-lang#122741

## Open questions

- [ ] Should the first unit test be split up?
- [ ] I don't see any guidance on ordering of methods in impl blocks, should I move the method elsewhere?
…ilee

Update `RwLock` deadlock example to not use shadowing

Tweak variable names in the deadlock example to remove any potential confusion that the behavior is somehow shadowing-related.
@rustbot rustbot added O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Mar 27, 2024
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=7

@bors
Copy link
Collaborator

bors commented Mar 27, 2024

📌 Commit bce5253 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 27, 2024
@bors
Copy link
Collaborator

bors commented Mar 27, 2024

⌛ Testing commit bce5253 with merge 37f9798...

@bors
Copy link
Collaborator

bors commented Mar 27, 2024

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 37f9798 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 27, 2024
@bors bors merged commit 37f9798 into rust-lang:master Mar 27, 2024
@rustbot rustbot added this to the 1.79.0 milestone Mar 27, 2024
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#122439 match lowering: build the Place instead of keeping a `Pla… 2a96015a0c42563c8826cfaec3cc5e906191565f (link)
#122880 Unix: Support more platforms with preadv and pwritev e806ab63d3746cb38ccc174d77acfec57c6e43d9 (link)
#123038 std library thread.rs: fix NetBSD code for ILP32 CPUs. 821da4bed7f3ce13abfcb7215e16f5916fa6fe4f (link)
#123084 UnixStream: override read_buf edf466b062000bfbc0d766ee1975989f741b2c65 (link)
#123102 RustWrapper: update call for llvm/llvm-project@44d037cc258d 4c1e47432f59e4e5ce7800e9c3a195f8785499bc (link)
#123107 Implement Vec::pop_if e6381973ab5c73f80c0c4e1241afcb282afffbe0 (link)
#123118 Update RwLock deadlock example to not use shadowing 5f907a587ab33e592071decb09a37e90f10b31bb (link)

previous master: 435b525514

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (37f9798): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.6% [0.5%, 0.7%] 4
Regressions ❌
(secondary)
2.8% [2.8%, 2.8%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.6% [-3.6%, -3.6%] 1
All ❌✅ (primary) 0.6% [0.5%, 0.7%] 4

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.0% [-1.4%, -0.4%] 5
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -1.0% [-1.4%, -0.4%] 5

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 670.407s -> 669.488s (-0.14%)
Artifact size: 315.71 MiB -> 315.76 MiB (0.01%)

@matthiaskrgr matthiaskrgr deleted the rollup-e4glcv3 branch September 1, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. O-unix Operating system: Unix-like rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants