Skip to content

Conversation

clubby789
Copy link
Contributor

Fixed all the cases of this found with some simple searches for */ bool and bool /*; probably many more

@rustbot
Copy link
Collaborator

rustbot commented Feb 14, 2024

r? @cjgillot

rustbot has assigned @cjgillot.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Feb 14, 2024
@clubby789 clubby789 added the C-cleanup Category: PRs that clean code up or issues documenting cleanup. label Feb 14, 2024
@cjgillot cjgillot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 18, 2024
@clubby789 clubby789 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 18, 2024
@bors
Copy link
Collaborator

bors commented Feb 20, 2024

☔ The latest upstream changes (presumably #121327) made this pull request unmergeable. Please resolve the merge conflicts.

@cjgillot
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Feb 25, 2024

📌 Commit 06e7739 has been approved by cjgillot

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 25, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 25, 2024
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#119590 (Stabilize `cfg_target_abi`)
 - rust-lang#120805 (make non-PartialEq-typed consts as patterns a hard error)
 - rust-lang#121060 (Add newtypes for bool fields/params/return types)
 - rust-lang#121284 (Add test cases for inlining compiler-private items)
 - rust-lang#121324 (pattern_analysis: factor out unspecialization)
 - rust-lang#121409 (Prevent cycle in implied predicates computation)
 - rust-lang#121513 (Fix sgx unit test compilation)
 - rust-lang#121570 (Make most bootstrap step types !Copy)
 - rust-lang#121586 (Don't use `unwrap()` in `ArrayIntoIter` lint when typeck fails)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7c88ea2 into rust-lang:master Feb 25, 2024
@rustbot rustbot added this to the 1.78.0 milestone Feb 25, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 25, 2024
Rollup merge of rust-lang#121060 - clubby789:bool-newtypes, r=cjgillot

Add newtypes for bool fields/params/return types

Fixed all the cases of this found with some simple searches for `*/ bool` and `bool /*`; probably many more
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants