Be less confident when `dyn` suggestion is not checked for object safety #120530

trevyn · 2024-01-31T15:37:39Z

#120275 no longer checks bare traits for object safety when making a dyn suggestion on Rust < 2021. In this case, qualify the suggestion with a note that the trait must be object safe, to prevent user confusion as seen in #116434

r? @fmease

compiler-errors · 2024-01-31T18:17:36Z

I don't see a problem with this. If fmease has issues, follow-up later xD

@bors r+ rollup

bors · 2024-01-31T18:17:38Z

📌 Commit 8d31a53 has been approved by compiler-errors

It is now in the queue for this repository.

…rors Be less confident when `dyn` suggestion is not checked for object safety rust-lang#120275 no longer checks bare traits for object safety when making a `dyn` suggestion on Rust < 2021. In this case, qualify the suggestion with a note that the trait must be object safe, to prevent user confusion as seen in rust-lang#116434 r? `@fmease`

…rors Be less confident when `dyn` suggestion is not checked for object safety rust-lang#120275 no longer checks bare traits for object safety when making a `dyn` suggestion on Rust < 2021. In this case, qualify the suggestion with a note that the trait must be object safe, to prevent user confusion as seen in rust-lang#116434 r? ``@fmease``

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#120484 (Avoid ICE when is_val_statically_known is not of a supported type) - rust-lang#120516 (pattern_analysis: cleanup manual impls) - rust-lang#120517 (never patterns: It is correct to lower `!` to `_`.) - rust-lang#120523 (Improve `io::Read::read_buf_exact` error case) - rust-lang#120528 (Store SHOULD_CAPTURE as AtomicU8) - rust-lang#120529 (Update data layouts in custom target tests for LLVM 18) - rust-lang#120530 (Be less confident when `dyn` suggestion is not checked for object safety) - rust-lang#120531 (Remove a bunch of `has_errors` checks that have no meaningful or the wrong effect) - rust-lang#120533 (Correct paths for hexagon-unknown-none-elf platform doc) r? `@ghost` `@rustbot` modify labels: rollup

matthiaskrgr · 2024-02-03T21:23:58Z

@bors r-
failed in https://github.com/rust-lang-ci/rust/actions/runs/7769229110/job/21188065200#step:26:10319 (cargo tests I assume)
#120536

trevyn · 2024-02-04T01:01:11Z

@fmease @compiler-errors @estebank So it looks like changing the "use dyn" suggestion from MachineApplicable to MaybeIncorrect breaks the cargo fix tests because it's no longer automatically applied.

Should I change it back to MachineApplicable (even though it's really not), remove the cargo fix tests, or... something else?

trevyn · 2024-02-06T19:42:34Z

@bors r=compiler-errors

bors · 2024-02-06T19:42:36Z

@trevyn: 🔑 Insufficient privileges: Not in reviewers

compiler-errors · 2024-02-06T19:47:13Z

Can you squash this into one commit?

trevyn · 2024-02-06T20:57:08Z

@compiler-errors done

compiler-errors · 2024-02-06T23:50:54Z

@bors r+

bors · 2024-02-06T23:50:57Z

📌 Commit 915812d has been approved by compiler-errors

It is now in the queue for this repository.

bors · 2024-02-09T18:56:43Z

☔ The latest upstream changes (presumably #120843) made this pull request unmergeable. Please resolve the merge conflicts.

rustbot · 2024-02-10T04:12:14Z

There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

You can start a rebase with the following commands:

$ # rebase
$ git rebase -i master
$ # delete any merge commits in the editor that appears
$ git push --force-with-lease

The following commits are merge commits:

338153f

trevyn · 2024-02-10T06:07:13Z

r? @compiler-errors

trevyn · 2024-02-10T06:11:01Z

@rustbot review

compiler-errors · 2024-02-12T15:57:12Z

@bors r+ rollup

bors · 2024-02-12T15:57:14Z

📌 Commit 29fd82b has been approved by compiler-errors

It is now in the queue for this repository.

…rors Be less confident when `dyn` suggestion is not checked for object safety rust-lang#120275 no longer checks bare traits for object safety when making a `dyn` suggestion on Rust < 2021. In this case, qualify the suggestion with a note that the trait must be object safe, to prevent user confusion as seen in rust-lang#116434 r? `@fmease`

…rors Be less confident when `dyn` suggestion is not checked for object safety rust-lang#120275 no longer checks bare traits for object safety when making a `dyn` suggestion on Rust < 2021. In this case, qualify the suggestion with a note that the trait must be object safe, to prevent user confusion as seen in rust-lang#116434 r? ``@fmease``

Rollup of 6 pull requests Successful merges: - rust-lang#120486 (Use generic `NonZero` internally.) - rust-lang#120500 (Implement intrinsics with fallback bodies) - rust-lang#120530 (Be less confident when `dyn` suggestion is not checked for object safety) - rust-lang#120563 (Make `NonZero::get` generic.) - rust-lang#120847 (Continue compilation after check_mod_type_wf errors) - rust-lang#120959 (Remove good path delayed bugs) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 13 pull requests Successful merges: - rust-lang#116387 (Additional doc links and explanation of `Wake`.) - rust-lang#118738 (Netbsd10 update) - rust-lang#118890 (Clarify the lifetimes of allocations returned by the `Allocator` trait) - rust-lang#120498 (Uplift `TypeVisitableExt` into `rustc_type_ir`) - rust-lang#120530 (Be less confident when `dyn` suggestion is not checked for object safety) - rust-lang#120915 (Fix suggestion span for `?Sized` when param type has default) - rust-lang#121015 (Optimize `delayed_bug` handling.) - rust-lang#121024 (implement `Default` for `AsciiChar`) - rust-lang#121039 (Correctly compute adjustment casts in GVN) - rust-lang#121045 (Fix two UI tests with incorrect directive / invalid revision) - rust-lang#121049 (Do not point at `#[allow(_)]` as the reason for compat lint triggering) - rust-lang#121071 (Use fewer delayed bugs.) - rust-lang#121073 (Fix typos in `OneLock` doc) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#120530 - trevyn:issue-116434, r=compiler-errors Be less confident when `dyn` suggestion is not checked for object safety rust-lang#120275 no longer checks bare traits for object safety when making a `dyn` suggestion on Rust < 2021. In this case, qualify the suggestion with a note that the trait must be object safe, to prevent user confusion as seen in rust-lang#116434 r? ```@fmease```

rustbot assigned fmease Jan 31, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 31, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 31, 2024

matthiaskrgr mentioned this pull request Jan 31, 2024

Rollup of 9 pull requests #120534

Closed

matthiaskrgr mentioned this pull request Jan 31, 2024

Rollup of 9 pull requests #120536

Closed

trevyn mentioned this pull request Feb 2, 2024

E0412 is correct but E0782 is emitted (in trait definitions) #116434

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 3, 2024

trevyn force-pushed the issue-116434 branch from a35ef99 to 915812d Compare February 6, 2024 19:48

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 6, 2024

bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 9, 2024

bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Feb 9, 2024

rustbot added the has-merge-commits PR has merge commits, merge with caution. label Feb 10, 2024

Be less confident when dyn suggestion is not checked for object safety

29fd82b

trevyn force-pushed the issue-116434 branch from 338153f to 29fd82b Compare February 10, 2024 04:48

rustbot removed the has-merge-commits PR has merge commits, merge with caution. label Feb 10, 2024

rustbot assigned compiler-errors and unassigned fmease Feb 10, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 10, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 12, 2024

oli-obk mentioned this pull request Feb 13, 2024

Rollup of 8 pull requests #121011

Closed

oli-obk mentioned this pull request Feb 13, 2024

Rollup of 6 pull requests #121013

Closed

oli-obk mentioned this pull request Feb 14, 2024

Rollup of 13 pull requests #121078

Merged

bors merged commit c4371a7 into rust-lang:master Feb 14, 2024

rustbot added this to the 1.78.0 milestone Feb 14, 2024

trevyn deleted the issue-116434 branch February 15, 2024 17:14

Be less confident when dyn suggestion is not checked for object safety #120530

Be less confident when dyn suggestion is not checked for object safety #120530

Uh oh!

Conversation

trevyn commented Jan 31, 2024

Uh oh!

compiler-errors commented Jan 31, 2024

Uh oh!

bors commented Jan 31, 2024

Uh oh!

matthiaskrgr commented Feb 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

trevyn commented Feb 4, 2024

Uh oh!

trevyn commented Feb 6, 2024

Uh oh!

bors commented Feb 6, 2024

Uh oh!

compiler-errors commented Feb 6, 2024

Uh oh!

trevyn commented Feb 6, 2024

Uh oh!

compiler-errors commented Feb 6, 2024

Uh oh!

bors commented Feb 6, 2024

Uh oh!

bors commented Feb 9, 2024

Uh oh!

rustbot commented Feb 10, 2024

Uh oh!

trevyn commented Feb 10, 2024

Uh oh!

trevyn commented Feb 10, 2024

Uh oh!

compiler-errors commented Feb 12, 2024

Uh oh!

bors commented Feb 12, 2024

Uh oh!

Uh oh!

Be less confident when `dyn` suggestion is not checked for object safety #120530

Be less confident when `dyn` suggestion is not checked for object safety #120530

matthiaskrgr commented Feb 3, 2024 •

edited

Loading