Skip to content

Conversation

cjgillot
Copy link
Contributor

This code has become unreachable with #107421.

@rustbot
Copy link
Collaborator

rustbot commented Sep 24, 2023

r? @davidtwco

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Sep 24, 2023
@rustbot
Copy link
Collaborator

rustbot commented Sep 24, 2023

This PR changes Stable MIR

cc @oli-obk, @celinval, @spastorino

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

@rust-log-analyzer

This comment has been minimized.

@cjgillot cjgillot force-pushed the drop-tracking-mir-noscope branch from 34fb823 to 3e6cb4c Compare September 24, 2023 09:17
@rustbot
Copy link
Collaborator

rustbot commented Sep 24, 2023

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

This PR changes Stable MIR

cc @oli-obk, @celinval, @spastorino

@rust-log-analyzer

This comment has been minimized.

@cjgillot cjgillot force-pushed the drop-tracking-mir-noscope branch from 3e6cb4c to 26cb34c Compare September 24, 2023 09:47
@compiler-errors
Copy link
Member

r? @compiler-errors @bors r+

@bors
Copy link
Collaborator

bors commented Sep 24, 2023

📌 Commit 26cb34c has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 24, 2023
@bors
Copy link
Collaborator

bors commented Sep 24, 2023

⌛ Testing commit 26cb34c with merge 91958e0...

@bors
Copy link
Collaborator

bors commented Sep 25, 2023

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 91958e0 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 25, 2023
@bors bors merged commit 91958e0 into rust-lang:master Sep 25, 2023
@rustbot rustbot added this to the 1.74.0 milestone Sep 25, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (91958e0): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.0% [1.0%, 1.0%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.3% [1.3%, 1.3%] 1
Regressions ❌
(secondary)
1.4% [0.6%, 4.1%] 6
Improvements ✅
(primary)
-3.3% [-4.5%, -1.2%] 5
Improvements ✅
(secondary)
-5.4% [-7.6%, -3.1%] 4
All ❌✅ (primary) -2.5% [-4.5%, 1.3%] 6

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 631.113s -> 631.523s (0.06%)
Artifact size: 317.17 MiB -> 317.27 MiB (0.03%)

@cjgillot cjgillot deleted the drop-tracking-mir-noscope branch September 25, 2023 06:23
@lcnr lcnr removed the WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) label Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants