Skip to content

Conversation

GuillaumeGomez
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Sep 3, 2023
@GuillaumeGomez
Copy link
Member Author

@bors r+ p=3 rollup=never

@bors
Copy link
Collaborator

bors commented Sep 3, 2023

📌 Commit 38a2d5f has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 3, 2023
@bors
Copy link
Collaborator

bors commented Sep 3, 2023

⌛ Testing commit 38a2d5f with merge 2a1af89...

@bors
Copy link
Collaborator

bors commented Sep 3, 2023

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing 2a1af89 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 3, 2023
@bors bors merged commit 2a1af89 into rust-lang:master Sep 3, 2023
@rustbot rustbot added this to the 1.74.0 milestone Sep 3, 2023
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#115478 Emit unused doc comment warnings for pat and expr fields b15a0b8b9e8bc334fd0e3dbacf092d37ce3be5ab (link)
#115490 rustdoc: update comment in search.js for #107629 f915d65fe47efe28a87d7d864861abe648c232da (link)
#115503 Migrate GUI colors test to original CSS color format 7424b5f43c43ff330e8bc6177dd139143ecf416d (link)

previous master: 49523e3360

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@GuillaumeGomez GuillaumeGomez deleted the rollup-wh719bn branch September 3, 2023 17:39
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (2a1af89): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.4% [0.4%, 0.4%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.4% [-0.4%, -0.4%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
4.9% [4.9%, 4.9%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 631.425s -> 629.273s (-0.34%)
Artifact size: 316.57 MiB -> 316.72 MiB (0.05%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants