-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Fix standard library not compiling with dependency cc v1.0.80+ #115032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(rustbot has picked a reviewer for you, use r? to override) |
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
The job Click to see the possible cause of the failure (guessed by this bot)
|
@@ -1,5 +1,5 @@ | |||
[workspace] | |||
resolver = "1" | |||
resolver = "2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just FYI, I don't think this change is feasible without doing a lot of work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, the CI run seems to think the same :)
I opened rust-lang/cc-rs#860 instead. Edit: Didn't work. But I'm not experienced enough with compilation of |
Noticed in #112865.
cc
(which is needed as a dev-dependency for compiling std) introduced a dependency tolibc
in 1.0.80 and has default features enabled for it. The Rust workspace where the standard lib resides currently uses the resolver v1, which faces this issue: rust-lang/cargo#10719 (it combines the features enabled for dev-dependencies with those for dependencies), so updating the resolver version is necessary.I also updated
cc
to make sure this fixes the problem.