pass clippy sysroot env if given #104619
Closed
pass clippy sysroot env if given #104619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ozkanonur <[email protected]>
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
|
r? @jyn514 |
|
Thanks! Please don't merge this in this repo. I will cherry pick this commit over to rust-lang/rust-clippy#9881 and then sync it to here. That way this will get tested in Clippy CI and we know that we're back in a backwards compatible state. |
matthiaskrgr
added
S-blocked
|
Cherry-picked and merged in rust-lang/rust-clippy#9881 into the Clippy repo and synced in #104688 with commit 5907e91, so can be closed now. Thanks again for addressing this so quickly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #103660 (comment)
cc @flip1995