[PERF] Normalize opaques with escaping bound vars in AssocTypeNormalizer#100903
Closed
compiler-errors wants to merge 1 commit intorust-lang:masterfrom
Closed
[PERF] Normalize opaques with escaping bound vars in AssocTypeNormalizer#100903compiler-errors wants to merge 1 commit intorust-lang:masterfrom
compiler-errors wants to merge 1 commit intorust-lang:masterfrom
Conversation
Contributor
Author
|
@bors try @rust-timer queue |
Collaborator
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
Collaborator
|
⌛ Trying commit a715948 with merge 41b4519665e895f6ac8cf481e8f8189567b04230... |
Contributor
Author
|
I'm so stupid. This won't work. QueryNormalizer and AssocTypeNormalizer need to agree, otherwise UI tests get angry. |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Collaborator
|
💔 Test failed - checks-actions |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue in #88862 mentioned the
QueryNormalizeras the source of too many bound vars, not theAssocTypeNormalizer... maybe just reverting this one and keeping the otherif !substs.has_escaping_bound_vars()will satisfy perf + let us fix the ICE in rust-lang/miri#2433. I may have no idea what I'm doing though.r? @ghost