Skip to content

Consistent tiers target naming #902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 1, 2025

Conversation

apiraino
Copy link
Contributor

@apiraino apiraino commented Jun 16, 2025

This may sound like incredible bikeshedding 😃 but I searched for "tier {1,2,3}" in the compiler proposals page and could not find matches. In my head I am used to identify them as I read in the Platform Support page (capitalized word followed by an arabic numeral)

Makes sense?

The second commit slightly clarifies what an FCP is, I'm not 100% sure it's a a widespread enough acronym to give it for granted.

Rendered

@rustbot
Copy link
Collaborator

rustbot commented Jun 16, 2025

r? @cuviper

rustbot has assigned @cuviper.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 16, 2025
@apiraino apiraino changed the title Consistent tier target naming Consistent tiers target naming Jun 16, 2025
@cuviper
Copy link
Member

cuviper commented Jun 16, 2025

I agree with switching to numerals, but I don't know about capitalizing it everywhere. The cited Platform Support page does not generally do that, only in titles and in links referencing those titles.

@apiraino
Copy link
Contributor Author

Done

(I'll squash before merging when there are no more comments - or opposing opinions to merge)

@apiraino apiraino force-pushed the consistent-target-tier-naming branch 2 times, most recently from dfd152b to fe8588e Compare June 19, 2025 13:42
Copy link
Member

@cuviper cuviper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cuviper cuviper enabled auto-merge July 1, 2025 18:38
@cuviper cuviper force-pushed the consistent-target-tier-naming branch from 636fcf6 to 6995c30 Compare July 1, 2025 18:39
@cuviper cuviper merged commit e0a16fb into rust-lang:master Jul 1, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants