Skip to content

Document users_on_vacation #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2024
Merged

Document users_on_vacation #759

merged 1 commit into from
Jul 17, 2024

Conversation

ChrisDenton
Copy link
Member

This doesn't seem to be documented anywhere at the moment.

@rustbot
Copy link
Collaborator

rustbot commented Jul 17, 2024

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 17, 2024
fmease
fmease reviewed Jul 17, 2024
View reviewed changes
fmease
fmease approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@fmease fmease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from that looks good to me

@fmease fmease merged commit b672411 into rust-lang:master Jul 17, 2024
1 check passed
@ChrisDenton ChrisDenton deleted the vacation branch July 17, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmease fmease fmease approved these changes

Assignees

@ehuss ehuss

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChrisDenton @rustbot @fmease @ehuss