I like to move it, move it #5190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flip1995
added
S-needs-discussion
|
No objections from my side =) |
phansch
approved these changes
Feb 18, 2020
|
We like to move it! |
flip1995
changed the title
flip1995
changed the title
|
@bors r=phansch,Manishearth,llogiq,flip1995 |
|
📌 Commit 6835e2d has been approved by |
bors
added a commit
that referenced
this pull request
Feb 19, 2020
…logiq,flip1995 I like to move it, move it GHA now runs in the background for 6 days (#5088) Since then ~~15~~ 19 PRs were successfully merged and Travis+Appveyor agreed on the status in every case. ([GitHub PR search query](https://github.com/rust-lang/rust-clippy/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Amerged+merged%3A%3E%3D2020-02-12T15%3A42%3A00+sort%3Aupdated-desc+NOT+%5Bgh-pages%5D+in%3Atitle)) Some PRs were: - #5163 - #5170 - #5168 - #5173 - #5171 - #5156 - #4809 - #5177 - #5182 - #5183 - #5184 - #5185 - #5186 - #5181 - #5189 Bug with GHA: - When a rustc PR gets merged between the `integration_build` and the `integration` job, the `integration` job will fail. This happened once in #5162, but not in the past 6 days. Even if it would happen every 4th PR we would save time, since splitting up the integration build and tests saves 5-7 minutes per run and a complete run takes 15-17 minutes - Sometimes the MacOS build takes up to an hour to download the master toolchain. Until now, this happend 2 or 3 times and can be resolved by a `@bors r3try`+canceling the previous run (restarting single jobs is not supported yet) ## Before merging this, rust-lang/rust-central-station#578 has to get merged This PR is for starting the discussion and to get consensus (@rust-lang/clippy) on a final move to GHA. If we're ready, I'll contact Pietro, to finalize the move. changelog: Clippy completely runs on GHA now 🎉 --- BTW: The deployment already runs on GHA, instead of Travis.
|
@Manishearth I think AppVeyor has to be disabled in the AppVeyor UI https://ci.appveyor.com/project/rust-lang-libs/rust-clippy/builds/30904772 (?) |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
bors
added a commit
that referenced
this pull request
Feb 19, 2020
[DNM] Test that bors fails successfully Merging works, if every test finishes successfully (#5190). Let's test if failing also works. changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GHA now runs in the background for 6 days (#5088)
Since then
1519 PRs were successfully merged and Travis+Appveyor agreed on the status in every case. (GitHub PR search query)Some PRs were:
zero_prefixed_literal#5170TypeckTables#5177single_component_path_importsin macros #5183pulldown-cmarksize #5184FunctionRetTytoFnRetTy#5186missing_errors_docto also work on async functions #5181Bug with GHA:
integration_buildand theintegrationjob, theintegrationjob will fail. This happened once in Fix GHA after the merge #5162, but not in the past 6 days. Even if it would happen every 4th PR we would save time, since splitting up the integration build and tests saves 5-7 minutes per run and a complete run takes 15-17 minutes@bors r3try+canceling the previous run (restarting single jobs is not supported yet)Before merging this, rust-lang/rust-central-station#578 has to get merged
This PR is for starting the discussion and to get consensus (@rust-lang/clippy) on a final move to GHA. If we're ready, I'll contact Pietro, to finalize the move.
changelog: Clippy completely runs on GHA now 🎉
BTW: The deployment already runs on GHA, instead of Travis.