Rustup #4857
Merged
Rustup #4857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matthewjasper could you have a look at this? Specifically the "fix categorizations" commit, I'm not sure if that's the right fix for the cases that were recursively looping Also, I'm not sure where I should be getting an infcx from, |
clippy_lints/src/escape.rs
Outdated
| fn consume(&mut self, cmt: &cmt_<'tcx>, mode: ConsumeMode) { | ||
| if let Categorization::Local(lid) = cmt.cat { | ||
| fn consume(&mut self, cmt: &Place<'tcx>, mode: ConsumeMode) { | ||
| if let PlaceBase::Local(lid) = cmt.base { |
There was a problem hiding this comment.
In this file there should also be a check that cmt.projections is empty.
There was a problem hiding this comment.
I just added it to every method of the EUV. It didn't break anything, so I think this should be ok?
flip1995
added
the
S-waiting-on-review
matthewjasper
approved these changes
Nov 29, 2019
|
@bors r=matthewjasper,oli-obk |
|
📌 Commit 604e6ba has been approved by |
bors
added a commit
that referenced
this pull request
Nov 29, 2019
Rustup From rust-lang/rust#66246 changelog: none
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From rust-lang/rust#66246
changelog: none