Don't error on clippy.toml of dependencies #4845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flip1995
added
the
S-waiting-on-review
|
☔ The latest upstream changes (presumably #4848) made this pull request unmergeable. Please resolve the merge conflicts. |
|
r=me with rebase |
flip1995
force-pushed
the
clippy_toml_deps
branch
from
b75f204 to
a61fd43
Compare
|
@bors r=phansch |
|
📌 Commit a61fd43 has been approved by |
bors
added a commit
that referenced
this pull request
Nov 28, 2019
Don't error on clippy.toml of dependencies Fixes #3874 Checking for `metadata` wasn't enough anymore. `--cap-lints allow` only appears when compiling deps though. changelog: none
flip1995
added
S-waiting-on-bors
|
💔 Test failed - status-appveyor |
|
@bors r=phansch |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit a61fd43 has been approved by |
bors
added a commit
that referenced
this pull request
Nov 29, 2019
Don't error on clippy.toml of dependencies Fixes #3874 Checking for `metadata` wasn't enough anymore. `--cap-lints allow` only appears when compiling deps though. changelog: none
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3874
Checking for
metadatawasn't enough anymore.--cap-lints allowonly appears when compiling deps though.changelog: none