Skip to content

Conversation

jolson88
Copy link
Contributor

As discussed in #4528, this moves the cast-lossless lint from all to pedantic.

I couldn't tell from description alone if it should also be removed from the complexity category, so I left it as part of complexity for now. I didn't see any impact to the tests from this change, but I could be wrong (as this is my first PR).

fixes #4528

changelog: Moves cast-lossless from default to checking only as a pedantic lint.

@ghost
Copy link

ghost commented Sep 13, 2019

You need to update the category where the lint is declared using the declare_clippy_lint! macro inside clippy_lints/src/types.rs. Then run ./utils/dev update_lints which will update all the other places where the lint category is used.

@flip1995 flip1995 added the S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) label Sep 13, 2019
@jolson88
Copy link
Contributor Author

Great! Thanks Mike. I'll do that this evening and get the PR updated :).

@jolson88
Copy link
Contributor Author

Updated and corrected tests. I think (?) that the build failures are from the needed change to the clippy-driver: rust-lang/rust#64440

@phansch
Copy link
Contributor

phansch commented Sep 15, 2019

going to retrigger the PR build

@phansch phansch closed this Sep 15, 2019
@phansch phansch reopened this Sep 15, 2019
@jolson88
Copy link
Contributor Author

Here's the PR and change that caused the new build failures: https://github.com/rust-lang/rust/pull/60584/files#diff-707a0eda6b2f1a0537abc3d23133748cL1151. I will get a new PR opened soon to fix that issue.

@jolson88
Copy link
Contributor Author

PR opened for the breaking change: #4545.

@flip1995
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 19, 2019

📌 Commit 6f1f413 has been approved by flip1995

flip1995 added a commit to flip1995/rust-clippy that referenced this pull request Sep 19, 2019
…lip1995

Changes cast-lossless to a pedantic lint

As discussed in rust-lang#4528, this moves the cast-lossless lint from `all` to `pedantic`.

I couldn't tell from description alone if it should also be removed from the complexity category, so I left it as part of complexity for now. I didn't see any impact to the tests from this change, but I could be wrong (as this is my first PR).

fixes rust-lang#4528

changelog: Moves cast-lossless from default to checking only as a `pedantic` lint.
flip1995 added a commit to flip1995/rust-clippy that referenced this pull request Sep 19, 2019
…lip1995

Changes cast-lossless to a pedantic lint

As discussed in rust-lang#4528, this moves the cast-lossless lint from `all` to `pedantic`.

I couldn't tell from description alone if it should also be removed from the complexity category, so I left it as part of complexity for now. I didn't see any impact to the tests from this change, but I could be wrong (as this is my first PR).

fixes rust-lang#4528

changelog: Moves cast-lossless from default to checking only as a `pedantic` lint.
bors added a commit that referenced this pull request Sep 19, 2019
Rollup of 4 pull requests

Successful merges:

 - #4511 (New lint: mem_replace_with_uninit)
 - #4535 (New lint: Require `# Safety` section in pub unsafe fn docs)
 - #4539 (Changes cast-lossless to a pedantic lint)
 - #4544 (#4542 remove machine applicable suggestion)

Failed merges:

r? @ghost

changelog: none
@bors
Copy link
Contributor

bors commented Sep 19, 2019

⌛ Testing commit 6f1f413 with merge f08f171...

bors added a commit that referenced this pull request Sep 19, 2019
Changes cast-lossless to a pedantic lint

As discussed in #4528, this moves the cast-lossless lint from `all` to `pedantic`.

I couldn't tell from description alone if it should also be removed from the complexity category, so I left it as part of complexity for now. I didn't see any impact to the tests from this change, but I could be wrong (as this is my first PR).

fixes #4528

changelog: Moves cast-lossless from default to checking only as a `pedantic` lint.
@bors
Copy link
Contributor

bors commented Sep 19, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing f08f171 to master...

@bors bors merged commit 6f1f413 into rust-lang:master Sep 19, 2019
@jolson88 jolson88 deleted the cast-lossless-pedantic branch September 19, 2019 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cast-lossless is too strict
4 participants