Rustup #3711
Merged
Rustup #3711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mati865
reviewed
Jan 28, 2019
| ty::Ref(_, tam, _) => match tam.sty { | ||
| ty::Str => { | ||
| let alloc = tcx.alloc_map.lock().unwrap_memory(ptr.alloc_id); | ||
| let offset = ptr.offset.bytes().try_into().expect("too-large pointer offset"); | ||
| let n = n as usize; | ||
| let n = usize::try_from(n).unwrap(); |
There was a problem hiding this comment.
Calling try_from() just to instantly unwrap it looks odd.
There was a problem hiding this comment.
Yea it is, but it's similar to foo.checked_add(bar).unwrap() which prevents silent overflow irrelevant of the compiler flags.
|
@bors r+ |
|
📌 Commit 6033294 has been approved by |
bors
added a commit
that referenced
this pull request
Jan 28, 2019
Rustup fixes #3709 I'm currently in the process of making rustc's deprecation lint emit the `AtomicFoo::new(0)` suggestion
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3709
I'm currently in the process of making rustc's deprecation lint emit the
AtomicFoo::new(0)suggestion