Dont ref operator args #1613
Merged
Dont ref operator args #1613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r+
So let us not merge now? |
|
I don't have an opinion on merging, except the open question about whether this lint should not trigger on literals in general |
oli-obk
added
the
S-needs-discussion
|
Rustc changes went through rust-lang/rust#40606 (comment) gotta wait for the nightly though |
oli-obk
force-pushed
the
dont_ref_operator_args
branch
from
43fdbd3 to
d9e69a7
Compare
oli-obk
removed
the
S-needs-discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore the second commit for now. I'm fixing rustc so we can compare
InternedStringandstrdirectly without any dereferences, references or whatnot.