Skip to content

fix(extra_unused_type_parameters): don't suggest an autofix #15907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(extra_unused_type_parameters): don't suggest an autofix #15907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clippy_lints/src/extra_unused_type_parameters.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ impl<'cx, 'tcx> TypeWalker<'cx, 'tcx> {
fn emit_sugg(&self, spans: Vec<Span>, msg: String, help: &'static str) {
let suggestions: Vec<(Span, String)> = spans.iter().copied().zip(std::iter::repeat(String::new())).collect();
span_lint_and_then(self.cx, EXTRA_UNUSED_TYPE_PARAMETERS, spans, msg, |diag| {
diag.multipart_suggestion(help, suggestions, Applicability::MachineApplicable);
diag.multipart_suggestion(help, suggestions, Applicability::MaybeIncorrect);
});
}

Expand Down
13 changes: 13 additions & 0 deletions tests/ui/extra_unused_type_parameters_unfixable.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
//@no-rustfix

#![warn(clippy::extra_unused_type_parameters)]

fn unused_where_clause<T, U>(x: U)
Expand All @@ -24,4 +26,15 @@ where
unimplemented!();
}

mod issue15884 {
fn unused_ty<T>(x: u8) {
//~^ extra_unused_type_parameters
unimplemented!()
}

fn main() {
unused_ty::<String>(0);
}
}

fn main() {}
14 changes: 10 additions & 4 deletions tests/ui/extra_unused_type_parameters_unfixable.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
error: type parameter `T` goes unused in function definition
--> tests/ui/extra_unused_type_parameters_unfixable.rs:3:24
--> tests/ui/extra_unused_type_parameters_unfixable.rs:5:24
|
LL | fn unused_where_clause<T, U>(x: U)
| ^
Expand All @@ -9,20 +9,26 @@ LL | fn unused_where_clause<T, U>(x: U)
= help: to override `-D warnings` add `#[allow(clippy::extra_unused_type_parameters)]`

error: type parameters go unused in function definition: T, V
--> tests/ui/extra_unused_type_parameters_unfixable.rs:11:30
--> tests/ui/extra_unused_type_parameters_unfixable.rs:13:30
|
LL | fn unused_multi_where_clause<T, U, V: Default>(x: U)
| ^ ^^^^^^^^^^
|
= help: consider removing the parameters

error: type parameters go unused in function definition: T, U, V
--> tests/ui/extra_unused_type_parameters_unfixable.rs:19:28
--> tests/ui/extra_unused_type_parameters_unfixable.rs:21:28
|
LL | fn unused_all_where_clause<T, U: Default, V: Default>()
| ^ ^^^^^^^^^^ ^^^^^^^^^^
|
= help: consider removing the parameters

error: aborting due to 3 previous errors
error: type parameter `T` goes unused in function definition
--> tests/ui/extra_unused_type_parameters_unfixable.rs:30:17
|
LL | fn unused_ty<T>(x: u8) {
| ^^^ help: consider removing the parameter

error: aborting due to 4 previous errors