Skip to content

Fix len_zero FP on unstable methods #15894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2025
Merged

Fix len_zero FP on unstable methods #15894

merged 1 commit into from
Oct 23, 2025

Conversation

@profetia
Copy link
Contributor

@profetia profetia commented Oct 16, 2025 •
edited by rustbot
Loading

Closes #15890

changelog: [len_zero] fix FP on unstable methods

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 16, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 16, 2025

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

samueltardieu
samueltardieu requested changes Oct 23, 2025
View reviewed changes
Copy link
Member

@samueltardieu samueltardieu left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r? samueltardieu
@rustbot author

View changes since this review

@rustbot rustbot assigned samueltardieu and unassigned Jarcho Oct 23, 2025
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Oct 23, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 23, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@profetia
Copy link
Contributor Author

Done. Thank you!

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Oct 23, 2025
samueltardieu
samueltardieu approved these changes Oct 23, 2025
View reviewed changes
Copy link
Member

@samueltardieu samueltardieu left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works even in const context because in general .len() and .is_empty() have been stabilized at the same time.

View changes since this review

@samueltardieu samueltardieu added this pull request to the merge queue Oct 23, 2025
Merged via the queue into rust-lang:master with commit 8ff0cf8 Oct 23, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samueltardieu samueltardieu samueltardieu approved these changes

Assignees

@samueltardieu samueltardieu

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

len_zero should not suggest unstable methods

4 participants

@profetia @rustbot @samueltardieu @Jarcho