Skip to content

fix(collapsible_span_lint_calls): use snippet_with_context for spans that are likely to contain macro expns #15881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(collapsible_span_lint_calls): use snippet_with_context for spans that are likely to contain macro expns #15881

wants to merge 3 commits into from
+162 −55

Conversation

ada4a
Copy link
Contributor

@ada4a ada4a commented Oct 13, 2025

Fixes #15880

changelog: none

@ada4a ada4a marked this pull request as ready for review October 13, 2025 18:03
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 13, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 13, 2025

r? @y21

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

ada4a added 3 commits October 13, 2025 20:05
@ada4a
clean-up
1566879 
- update file name to match lint name
- use `Symbol`s instead of `&str`s
- get rid of needless lifetimes
@ada4a
fix: use snippet_with_context for spans that are likely to contain …
4d79522 
…macro expns
@ada4a
s/snippet/snippet_with_applicability while we're at it
b270954
@ada4a ada4a force-pushed the 15880-collapsible_calls branch from 03ff6e6 to b270954 Compare October 13, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@y21 y21

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

collapsible_span_lint_calls mangles macro invocations

3 participants

@ada4a @rustbot @y21