allow explicit deref or deref_mut method calls in impl of Deref or DerefMut trait
#15688
Conversation
rustbot
added
the
S-waiting-on-review
|
Lintcheck changes for 6129b52
This comment will be updated if you push new changes |
This comment has been minimized.
This comment has been minimized.
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
r? clippy |
relaxcn
changed the title
deref or deref_mut impl of `D…deref impl of Deref trait
… or `DerefMut` trait
relaxcn
changed the title
deref impl of Deref traitderef or deref_mut method calls in impl of Deref or DerefMut trait
|
@rustbot ready |
There was a problem hiding this comment.
Sorry for the possible confusion @relaxcn – I'm not actually a member of the Clippy Team and so I unfortunately can't merge this PR. But I think it's in a pretty good shape now, and we'll just need to wait for the actual reviewer to take a final look and approve – the reviewers are usually quite busy, so it can take a bit 😅
| mutbl, | ||
| } => { | ||
| // Skip when inside implementation of the `Deref` or `DerefMut` trait. | ||
| if in_deref_or_deref_mut_impl { |
There was a problem hiding this comment.
I think this will end up allowing deref in DerefMut and vice versa, which could technically be solved by having a separate bool for each.. but honestly it might just be okay
There was a problem hiding this comment.
I had created a PR to rustc, but it seems that they don't want to add a new diag item refer rust-lang/rust#147643.
There was a problem hiding this comment.
Honestly the suggestion to look-up both diagnostic and language items in the same call makes a lot of sense. I'll open a Zulip thread to discuss it with the team, if I don't forget. Thank you for giving it a go though:)
| /// let _ = <Foo as Deref>::deref(&foo); | ||
| /// ``` | ||
| /// | ||
| /// This lint also excludes explicit `deref` or `deref_mut` method calls inside implementations of the `Deref` or `DerefMut` traits. |
There was a problem hiding this comment.
I think such additional information should go into the "What it does" section
|
@y21 friendly ping |
5 participants
Fixes: #15392
changelog: [
explicit_deref_methods]: Allow explicitdereforderef_mutmethod calls in implementation of the theDereforDerefMuttrait.