-
Notifications
You must be signed in to change notification settings - Fork 1.8k
significant_drop_tightening
: handle complex let-stmts
#15603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
significant_drop_tightening
: handle complex let-stmts
#15603
Conversation
r? @Alexendoo rustbot has assigned @Alexendoo. Use |
r? clippy |
Error: Parsing assign command in comment failed: ...'' | error: specify user to assign to at >| ''... Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #triagebot on Zulip. |
Lintcheck changes for 519964e
This comment will be updated if you push new changes |
210ffb7
to
5b61106
Compare
This comment has been minimized.
This comment has been minimized.
5b61106
to
519964e
Compare
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
☔ The latest upstream changes (possibly eee8ef8) made this pull request unmergeable. Please resolve the merge conflicts. |
I'm a bit unsure about those two suggestions. Is there a way we can do that without it becoming unrustfixable? |
Fixes #15602
This implements the "make the reconstruction more robust" approach, because the other one turned out to be somewhat complicated -- one would need to find the exact place the temporary was used in, and suggest replacing exactly that.
Based on #15598, but mostly for easier rebasing later.
changelog: [
significant_drop_tightening
]: handle complex let-statements