Skip to content

Fix match_single_binding suggests wrongly inside tuple #15539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix match_single_binding suggests wrongly inside tuple #15539

wants to merge 2 commits into from
+354 −25

Conversation

profetia
Copy link
Contributor

@profetia profetia commented Aug 22, 2025 •
edited by rustbot
Loading

Closes #15537
Closes #15840

changelog: [match_single_binding] fix wrong suggestions inside tuple

@rustbot
Copy link
Collaborator

rustbot commented Aug 22, 2025

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 22, 2025
ada4a
ada4a reviewed Aug 24, 2025
View reviewed changes
samueltardieu
samueltardieu reviewed Aug 26, 2025
View reviewed changes
Jarcho
Jarcho requested changes Aug 29, 2025
View reviewed changes
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Aug 29, 2025
@profetia
Copy link
Contributor Author

@Jarcho Updated. Thank you!

@profetia profetia requested a review from Jarcho August 31, 2025 19:18
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Aug 31, 2025
Jarcho
Jarcho reviewed Sep 2, 2025
View reviewed changes
@profetia profetia force-pushed the issue15537 branch 2 times, most recently from d7553fc to 00e4c58 Compare September 2, 2025 19:44
@profetia profetia requested a review from Jarcho September 2, 2025 19:46
@rustbot
Copy link
Collaborator

rustbot commented Oct 10, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@profetia
Copy link
Contributor Author

Also closes #15840

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samueltardieu samueltardieu samueltardieu left review comments

@Jarcho Jarcho Awaiting requested review from Jarcho

+1 more reviewer

@ada4a ada4a ada4a left review comments

Reviewers whose approvals may not affect merge requirements

Requested changes must be addressed to merge this pull request.

Assignees

@Jarcho Jarcho

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Milestone

No milestone

5 participants

@profetia @rustbot @samueltardieu @Jarcho @ada4a