Move uninlined_format_args back to style

[nyurik]

The uninlined_format_args was temporarily downgraded to pedantic in part because rust-analyzer was not fully supporting it at the time, per #10087. The support has been added over a year ago, so seems like this should be back to style.

Another source of the initial frustration was fixed since then as well - this lint does not trigger by default in case only some arguments can be inlined.

changelog: [uninlined_format_args]: move back to style

[rustbot]

r? @Centri3

rustbot has assigned @Centri3.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[nyurik]

r? @Alexendoo

[nyurik]

@samueltardieu I tried to minimize churn - reducing the changes. I just pushed the new commit making all tests a bit more consistent, where every test now has a different error line - making it much harder to review.

[Alexendoo]

cc https://rust-lang.zulipchat.com/#narrow/channel/257328-clippy/topic/uninlined_format_args.20.20category

Don't worry about the line number changes, we're very used to scrolling past them

[Finomnis]

This lint is very annoying for a bunch of people. A lot of people prefer the {} annotation. It's the first time that I had to pretty much add an ignore for a lint in all of my repositories.

Is there any chance this could get moved back to pedantic? Because that's where it rightfully belongs, in my opinion.

For example, I definitely do not want the lint here:

fn examine_report(error: impl miette::Diagnostic + Sync + Send + 'static) {
    println!("{}", error);
    println!("{:?}", error);
    println!("{:?}", error.source());
    println!("{}", error.code().unwrap());
    // Convert to report
    let report: miette::Report = error.into();
    println!("{}", report);
    println!("{:?}", report);
    // Convert to std::error::Error
    let boxed_error: BoxedError = report.into();
    println!("{}", boxed_error);
    println!("{:?}", boxed_error);
}