Skip to content

Conversation

samueltardieu
Copy link
Member

changelog: [needless_continue]: check labels before warning about continue as the last statement in a loop body

Fix #13641

@rustbot
Copy link
Collaborator

rustbot commented Nov 3, 2024

r? @Centri3

rustbot has assigned @Centri3.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 3, 2024
@Centri3
Copy link
Member

Centri3 commented Nov 3, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Nov 3, 2024

📌 Commit 2f1b7b6 has been approved by Centri3

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Nov 3, 2024

⌛ Testing commit 2f1b7b6 with merge ccf7c88...

@bors
Copy link
Contributor

bors commented Nov 3, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Centri3
Pushing ccf7c88 to master...

@bors bors merged commit ccf7c88 into rust-lang:master Nov 3, 2024
8 checks passed
@samueltardieu samueltardieu deleted the push-rpxvoukpolvm branch December 30, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

False positive on needless_continue when continuing to outer label without a nested if block

4 participants