Skip to content

Extend large_include_file lint to also work on attributes #13636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2024
Merged

Extend large_include_file lint to also work on attributes #13636

merged 1 commit into from
Oct 31, 2024

Conversation

GuillaumeGomez
Copy link
Member

I realized randomly while working on another lint that large_include_file was not emitted on attributes. This PR fixes that.

changelog: Extend large_include_file lint to also work on attributes

@rustbot
Copy link
Collaborator

rustbot commented Oct 30, 2024

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 30, 2024
dswij
dswij approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@dswij dswij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@dswij
Copy link
Member

dswij commented Oct 31, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Oct 31, 2024

📌 Commit 0c29fcc has been approved by dswij

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 31, 2024

⌛ Testing commit 0c29fcc with merge e1fa1b2...

@bors
Copy link
Contributor

bors commented Oct 31, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: dswij
Pushing e1fa1b2 to master...

@bors bors merged commit e1fa1b2 into rust-lang:master Oct 31, 2024
8 checks passed
@GuillaumeGomez GuillaumeGomez deleted the extend-large_include_file branch October 31, 2024 09:37
@bors bors mentioned this pull request Oct 31, 2024
Merged
@Veetaha Veetaha mentioned this pull request Nov 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dswij dswij dswij approved these changes

Assignees

@dswij dswij

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@GuillaumeGomez @rustbot @dswij @bors