Skip to content

Conversation

@nyurik
Copy link
Contributor

@nyurik nyurik commented Oct 30, 2024

Reorder the suggested code for the IntoIterator to match the ordering of the trait declaration:

impl IntoIterator for ... {
    type Item = ...;
    type IntoIter = ...;

changelog: none

Reorder the suggested code for the `IntoIterator` to match the ordering of the trait declaration:

```rust
impl IntoIterator for ... {
    type Item = ...;
    type IntoIter = ...;
```
@rustbot
Copy link
Collaborator

rustbot commented Oct 30, 2024

r? @xFrednet

rustbot has assigned @xFrednet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 30, 2024
@xFrednet
Copy link
Contributor

LGTM, thanks :D


Roses are red,
@samueltardieu approves,
I like the changes,
the suggestion is new

@bors
Copy link
Contributor

bors commented Oct 31, 2024

📌 Commit 323f144 has been approved by xFrednet,samueltardieu

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 31, 2024

⌛ Testing commit 323f144 with merge 8568ca8...

@bors
Copy link
Contributor

bors commented Oct 31, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet,samueltardieu
Pushing 8568ca8 to master...

@bors bors merged commit 8568ca8 into rust-lang:master Oct 31, 2024
8 checks passed
@nyurik nyurik deleted the fix-iter-without-into branch November 12, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants