Skip to content

Conversation

smoelius
Copy link
Contributor

@smoelius smoelius commented Oct 22, 2024

Fixes #13578

r? @Alexendoo

changelog: don't consider lifetimes in bounded types unused (fix extra_unused_lifetimes FP #13578)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 22, 2024
@smoelius smoelius changed the title Don't consider lifetimes in bounded types unused (fix needless_lifetimes FP #13578) Don't consider lifetimes in bounded types unused (fix extra_unused_lifetimes FP #13578) Oct 22, 2024
Copy link
Member

@Alexendoo Alexendoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Alexendoo Alexendoo enabled auto-merge November 18, 2024 20:06
@Alexendoo Alexendoo closed this Nov 18, 2024
auto-merge was automatically disabled November 18, 2024 20:07

Pull request was closed

@Alexendoo Alexendoo reopened this Nov 18, 2024
@Alexendoo Alexendoo enabled auto-merge November 18, 2024 20:07
@Alexendoo Alexendoo added this pull request to the merge queue Nov 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 18, 2024
@smoelius
Copy link
Contributor Author

Please let me know if I should do something.

@Alexendoo
Copy link
Member

Maybe a network error, not sure, let's try it again

@Alexendoo Alexendoo added this pull request to the merge queue Nov 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 18, 2024
@Alexendoo
Copy link
Member

Weird, maybe give it a rebase + push

@Alexendoo Alexendoo added this pull request to the merge queue Nov 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 18, 2024
changelog: don't consider lifetimes in bounded types unused (fix `extra_unused_lifetimes` FP rust-lang#13578)
@smoelius smoelius changed the title Don't consider lifetimes in bounded types unused (fix extra_unused_lifetimes FP #13578) Don't consider lifetimes in bounded types unused (fix extra_unused_lifetimes FP) Nov 19, 2024
@smoelius
Copy link
Contributor Author

@Alexendoo I renamed the PR in the hope of allowing it to be merged.

@Alexendoo Alexendoo added this pull request to the merge queue Nov 19, 2024
Merged via the queue into rust-lang:master with commit 10677c3 Nov 19, 2024
9 checks passed
@smoelius smoelius deleted the fix-13578 branch November 19, 2024 16:16
@smoelius
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

extra_unused_lifetimes false positive regression from 1.82 to 1.83

3 participants