Allow semantic tokens for strings to be disabled #8795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoops forgot to run all the doc generating stuff. Should be all set now. Also any suggestions for alternate docstrings and/or names for the new config option would be very welcome. |
|
bors r+ Thanks! I'll adjust config name in a follow-up PR |
|
It feels like this is a weird layer to implement and test it, but.. |
|
The layer I think is OK -- this is a work-around for the client impl, so it belongs to the lsp layer, and not to the ide. Agree that it doesn't make sense to spend an integration test here, I'll adjust that as well (don't want to make the PR enter a round of reviers, it's been waiting way too long already) |
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7111
Pretty straightforward change, but open to any suggestions if there's a more recommended testing strategy than what I went with.