Skip to content

Allow semantic tokens for strings to be disabled #8795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 17, 2021

Conversation

djrenren
Copy link
Contributor

Fixes #7111

Pretty straightforward change, but open to any suggestions if there's a more recommended testing strategy than what I went with.

@djrenren
Copy link
Contributor Author

Whoops forgot to run all the doc generating stuff. Should be all set now. Also any suggestions for alternate docstrings and/or names for the new config option would be very welcome.

@matklad
Copy link
Member

matklad commented May 17, 2021

bors r+

Thanks! I'll adjust config name in a follow-up PR

@lnicola
Copy link
Member

lnicola commented May 17, 2021

It feels like this is a weird layer to implement and test it, but..

@matklad
Copy link
Member

matklad commented May 17, 2021

The layer I think is OK -- this is a work-around for the client impl, so it belongs to the lsp layer, and not to the ide.

Agree that it doesn't make sense to spend an integration test here, I'll adjust that as well (don't want to make the PR enter a round of reviers, it's been waiting way too long already)

@matklad
Copy link
Member

matklad commented May 17, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented May 17, 2021

@bors bors bot merged commit f9d4a9e into rust-lang:master May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Semantic string tokens vs injected syntax
3 participants