Add fixes for non_exhaustive_let diagnostic #20762
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Veykril
reviewed
Oct 26, 2025
Comment on lines
41
to
44
| let insert_offset = let_stmt | ||
| .semicolon_token() | ||
| .map(|it| it.text_range().start()) | ||
| .unwrap_or_else(|| let_stmt.syntax().text_range().end()); |
There was a problem hiding this comment.
This offset might be within a macro expansion due to the above d.pat.value.to_node(&root) call. So we need to upmap things out of macro expansions here to accommodate for that
Example
---
```rust
fn foo() {
let None$0 = Some(5);
}
```
->
```rust
fn foo() {
let None = Some(5) else { return };
}
```
A4-Tacks
force-pushed
the
non-exhaustive-let-fixes
branch
from
e837d66 to
8c29f73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example
->