internal: Utilize cargo check --compile-time-deps
#20047
Merged
+24
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
😍 |
|
Do we want to disable |
|
We should not set the wrapper if we use the flag |
ShoyuVanilla
force-pushed
the
comp-time-deps
branch
from
4740f65 to
98c92fa
Compare
Oh, I missed it. Thanks! |
Veykril
approved these changes
Jun 21, 2025
|
This is amazing, can't wait to get rid of the wrapper in the future |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rust-lang/cargo#15674 has been merged and I guess it would be available in toolchain
1.90.0I've tested this on rust-analyzer itself with cargo binary built from current master with the following my rust-analyzer branch
https://github.com/ShoyuVanilla/rust-analyzer/tree/comp-time-deps-test
and these are the results (I had run
cargo cleanbefore each run and modified the code a bit to use--compile-time-depswith injected cargo binary path iff env var$CARGO_BIN_FOR_TESTis set)With
--compile-time-depsWithout
--compile-time-depsComparison
analysis-statresultstargetdir size--compile-time-depsSystem Information