-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(assists): Make raw string unescaped #1922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think it's better to only have two assists
In general, adding many assists is bad, because it makes it harder to find the correct one among the noise. The assists should be semantic preserving. This is not entirely true at the moment: make raw string of
(not also a hash: I thin it's a good idea to add one hash by default, as, if you don't need hashes, it's easy to just add |
So we're discarding the proposal from @bjorn3? (fine by me, just to be sure) I can add the hash by default. Do we keep "add hash" and "remove hash" assists? |
Yeah, I feel like having two flavors of the thing would be more confusing than helpful.
Yep, as they are only available if there's already a string literal. |
Add max_hashes_streak + 1 hashes to the raw string
Count `"#*` streak only, extract the counting in a function, unit test this function
bors r+ Thanks! |
1922: feat(assists): Make raw string unescaped r=matklad a=Geobert Last piece of #1730 Co-authored-by: Geobert Quach <[email protected]>
Build succeeded |
Last piece of #1730