feat(assists): raw string <-> usual string manipulation #1850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn3
reviewed
Sep 15, 2019
matklad
reviewed
Sep 16, 2019
|
uh, I don't know what I've done with git Oo EDIT: fixed |
added 5 commits
September 19, 2019 22:12
Geobert
force-pushed
the
raw-string-assists
branch
from
cf96735 to
ce4d843
Compare
matklad
reviewed
Sep 20, 2019
| let start_of_inside = usual_string_range.start().to_usize() + 1; | ||
| let end_of_inside = usual_string_range.end().to_usize(); | ||
| let inside_str = &text[start_of_inside..end_of_inside]; | ||
| let escaped = inside_str.escape_default().to_string(); |
There was a problem hiding this comment.
Nice, I haven't realized that we can lean on escape_default here!
There was a problem hiding this comment.
Me neither x) I was looking on what's available to achieve the work and stumble upon this :D
bors bot
added a commit
that referenced
this pull request
Sep 20, 2019
1850: feat(assists): raw string <-> usual string manipulation r=matklad a=Geobert Fixes #1730 Co-authored-by: Geobert Quach <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1730