Add config for disabling hover memory layout data #14758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Veykril
reviewed
May 7, 2023
crates/rust-analyzer/src/config.rs
Outdated
| hover_links_enable: bool = "true", | ||
| /// Whether to show memory layout data on hover. | ||
| hover_memory_layout_enable: bool = "true", |
There was a problem hiding this comment.
Suggested change
| hover_memory_layout_enable: bool = "true", | |
| hover_memoryLayout_enable: bool = "true", |
Let's treat this as one thing
There was a problem hiding this comment.
Makes sense, thank you. Fixed it.
HKalbasi
reviewed
May 7, 2023
| } else { | ||
| def.display(db).to_string() | ||
| let label = match value_extractor(&def) { | ||
| Some(value) if config.memory_layout => format!("{} // {value}", def.display(db)), |
There was a problem hiding this comment.
Unfortunately closure hover doesn't use label_and_layout_info_and_docs, but it shows some layout info which needs to be disabled.
There was a problem hiding this comment.
Thank you, I missed that closures use a different implementation.
I've added an additional test for closures.
|
@bors r+ |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested in #14748 (comment)