Skip to content

minor: Explicitly disable the rust-analyzer extension in untrusted workspaces #14112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Feb 9, 2023

This is the default, but its always better to be explicit here + we can add a small note as to why.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 9, 2023
@Veykril Veykril marked this pull request as ready for review February 9, 2023 16:36
@Veykril Veykril changed the title Explicitly disable the rust-analyzer extension in untrusted workspaces minor: Explicitly disable the rust-analyzer extension in untrusted workspaces Feb 9, 2023
@lnicola
Copy link
Member

lnicola commented Feb 9, 2023

Hmm. Ideally, we would:

  • disable build scripts, proc macros and check on save: this might be doable
  • not respect paths from settings.json (does Code even load that from untrusted workspaces?): this is probably harder

@Veykril
Copy link
Member Author

Veykril commented Feb 9, 2023

Ye that would be the goal #9224

@lnicola
Copy link
Member

lnicola commented Feb 9, 2023

Okay, we can disable it now and fix it properly at some point in the future.

@bors r+

@bors
Copy link
Contributor

bors commented Feb 9, 2023

📌 Commit 7fc0f89 has been approved by lnicola

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Feb 9, 2023

⌛ Testing commit 7fc0f89 with merge c468e39...

@bors
Copy link
Contributor

bors commented Feb 9, 2023

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing c468e39 to master...

@bors bors merged commit c468e39 into rust-lang:master Feb 9, 2023
@Veykril Veykril deleted the vscode-untrusted branch February 9, 2023 19:25
@Veykril
Copy link
Member Author

Veykril commented Feb 9, 2023

Note that it was disabled before as well already (it's the default with extensions that have an activation function afaik), this just adds a description as to why.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants