Skip to content

fix: fix "unwrap on a None value" in proc macros built with Rust 1.57.0 #11797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2022
Merged

fix: fix "unwrap on a None value" in proc macros built with Rust 1.57.0 #11797

merged 1 commit into from
Mar 23, 2022

Conversation

jonas-schievink
Copy link
Contributor

Closes #10570

cc #10769 (comment)

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 23, 2022

Build succeeded:

@bors bors bot merged commit cdd1477 into rust-lang:master Mar 23, 2022
@jonas-schievink jonas-schievink deleted the fix-proc-macro-abi-for-1.57 branch March 23, 2022 11:33
@jonas-schievink jonas-schievink mentioned this pull request Mar 23, 2022
Closed
lnicola
lnicola reviewed Mar 23, 2022
View reviewed changes
crates/proc_macro_srv/src/abis/abi_1_57/mod.rs
@@ -0,0 +1,104 @@
//! Macro ABI for version 1.58 of rustc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.57

@vlad20012 vlad20012 mentioned this pull request Mar 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lnicola lnicola lnicola left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Called Option::unwrap() on a None value, warning in simple hello world Rocket app
2 participants
@jonas-schievink @lnicola