This repository was archived by the owner on Dec 29, 2022. It is now read-only.
The call can be inside the new thread to avoid crashing RLS if it fails #481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For context: #181 (comment). |
nrc
reviewed
Sep 18, 2017
src/actions/requests.rs
Outdated
| let analysis = ctx.analysis.clone(); | ||
|
|
||
| let handle = thread::spawn(move || { | ||
| let type_id = analysis.id(&span).expect("Analysis: Getting typeid from span"); |
There was a problem hiding this comment.
Could we use ? rather than expect here to return an error?
|
I didn't have much time this week, but now I updated the PR. @nrc |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.