-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Reserve more numeric types. #907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
- Start Date: 2014-06-25 | ||
- RFC PR #: (leave this empty) | ||
- Rust Issue #: (leave this empty) | ||
|
||
# Summary | ||
|
||
Reserve more numeric types. | ||
|
||
# Motivation | ||
|
||
It is conceivable that Rust will gain support for types such as `f128`, `f16`, | ||
or `u128`. In the interest of backwards compatability, extend the grammar to | ||
reserve these. | ||
|
||
Adding them is backwards incompatible because `type PRIMITIVE = T;` is an error. | ||
|
||
# Detailed design | ||
|
||
Reserve the following type names: `fN`, `uN`, `iN` for `N` a multiple of 8. | ||
|
||
Reserve additionally `dN` for decimal floating point numbers. | ||
|
||
Reserve additionally `mN` for SSE. | ||
|
||
# Drawbacks | ||
|
||
Makes the grammar larger for types which we may never use. | ||
|
||
# Alternatives | ||
|
||
New types could require a flag to be enabled. | ||
|
||
C99 uses `_Bool` instead of `bool` because `_T` is reserved. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What limit? Or just to, say, 232?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whatever the parser can handle.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The parser can handle arbitrarily large numbers: congruence mod 8 can be determined using only the last 3 digits of a number represented in base 10, meaning string handling works fine, and hence
i1234567891234567891234567891234567800
could be checked to be "valid" under that rule.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason to limit ourselves to numbers that are a multiple of 8? Why not just reserve them for all numbers?